Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mono][wasm] Fix the passing/returning of small vtypes. #62299

Merged
merged 1 commit into from
Dec 3, 2021
Merged

[mono][wasm] Fix the passing/returning of small vtypes. #62299

merged 1 commit into from
Dec 3, 2021

Conversation

vargaz
Copy link
Contributor

@vargaz vargaz commented Dec 2, 2021

According to the ABI, they need to be returned by value.

@vargaz
[mono][wasm] Fix the passing/returning of small vtypes.
6fb6d49 
According to the ABI, they need to be returned by value.
lateralusX
lateralusX approved these changes Dec 3, 2021
View reviewed changes
Copy link
Member

@lateralusX lateralusX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mini-llvm.h|c changes looks good to me, have been extending it on win64 with similar solution and that pass all mini regression tests using full AOT LLVM.

@vargaz vargaz merged commit 915ee6d into dotnet:main Dec 3, 2021
@vargaz vargaz deleted the wasm-aot-vtype2 branch December 3, 2021 19:38
vargaz added a commit to vargaz/runtime that referenced this pull request Dec 5, 2021
@vargaz
Revert "[mono][wasm] Fix the passing/returning of small vtypes. (dotn…
a202b89 
…et#62299)"

This reverts commit 915ee6d.

This causes test failures in the System.Collections.Immutable testsuite on wasm.
@ghost ghost locked as resolved and limited conversation to collaborators Jan 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lateralusX lateralusX lateralusX approved these changes

@EgorBo EgorBo Awaiting requested review from EgorBo

@imhameed imhameed Awaiting requested review from imhameed

@lambdageek lambdageek Awaiting requested review from lambdageek

@SamMonoRT SamMonoRT Awaiting requested review from SamMonoRT

Assignees
No one assigned
Labels
area-Codegen-LLVM-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vargaz @lateralusX