Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update branding to 6.0.2 #62493

Merged

Conversation

vseanreesermsft
Copy link

No description provided.

@ghost
Copy link

ghost commented Dec 7, 2021

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: vseanreesermsft
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@wtgodbe
Copy link
Member

wtgodbe commented Dec 7, 2021

@safern do we need to worry about the failures here?

@safern
Copy link
Member

safern commented Dec 7, 2021

I investigated, the tests are failing because the ref pack is not produced (because we don't always service them and I don't know if we need to service it for 6.0.2, we will see depending if there are any source gen fixes), this got broken when we moved to the new shared framework SDK, because of the removal of this: 86d5d16#diff-e6fa12be37bfb84da12f2bcd51e00bb6a8b346f3aa35a6c64ea0f7cb67acaf4dL37

I will need to fix that, but we also need to address this to tighten the test condition that it is expected that the ref pack shouldn't be produced:
#3836

@safern
Copy link
Member

safern commented Dec 7, 2021

I've pushed a fix. @jkoritzinsky could you PTAL?

Copy link
Member

@jkoritzinsky jkoritzinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly I feel at this point that we can probably remove those tests and add comparable ones in Arcade itself. That's probably the best place for them to live anyway.

@safern
Copy link
Member

safern commented Dec 7, 2021

Honestly I feel at this point that we can probably remove those tests and add comparable ones in Arcade itself. That's probably the best place for them to live anyway.

Maybe we should update #3836 to express that?

@safern safern merged commit cfb9e77 into dotnet:release/6.0 Dec 8, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jan 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants