Code

Faster IndexOf for substrings#63285

Code

Merged

stephentoub merged 48 commits intodotnet:maindotnet/runtime:mainfrom EgorBo:vectorize-indexofEgorBo/runtime-1:vectorize-indexofCopy head branch name to clipboardJan 25, 2022

+833-62

Commits

Commits on Jan 7, 2022

• Improve "lastChar == firstChar" case, also, use IndexOf directly if value.Length == 1

  EgorBo

  committed
  34bf37a

  Copy full SHA for 34bf37a

• Merge branch 'main' of https://github.com/dotnet/runtime into vectorize-indexof

  EgorBo

  committed
  03ae4da

  Copy full SHA for 03ae4da

• Try plain IndexOf first, to optimize cases where even first char of value is never met

  EgorBo

  committed
  5cfdb16

  Copy full SHA for 5cfdb16

• Merge branch 'main' of github.com:dotnet/runtime into vectorize-indexof

  EgorBo

  committed
  0638617

  Copy full SHA for 0638617

• add 1-byte implementation

  EgorBo

  committed
  e36fdc6

  Copy full SHA for e36fdc6

• copyrights

  EgorBo

  committed
  85c2320

  Copy full SHA for 85c2320

• fix copy-paste mistake

  EgorBo

  committed
  8918ab6

  Copy full SHA for 8918ab6

Commits on Jan 8, 2022

• Initial LastIndexOf impl

  EgorBo

  committed
  cb32d34

  Copy full SHA for cb32d34

• More efficient LastIndexOf

  EgorBo

  committed
  cda6b50

  Copy full SHA for cda6b50

• fix bug in Char version (we need two clear two lowest bits in the mask) & temporarily remove AdvSimd impl

  EgorBo

  committed
  8af9270

  Copy full SHA for 8af9270

• use ResetLowestSetBit

  EgorBo

  committed
  87c26d0

  Copy full SHA for 87c26d0

• Fix bug

  EgorBo

  committed
  652b42d

  Copy full SHA for 652b42d

• Add two-byte LastIndexOf

  EgorBo

  committed
  53cefad

  Copy full SHA for 53cefad

• Fix build

  EgorBo

  committed
  d465407

  Copy full SHA for d465407

Commits on Jan 9, 2022

• Merge branch 'main' of https://github.com/dotnet/runtime into vectorize-indexof

  EgorBo

  committed
  22921fd

  Copy full SHA for 22921fd

• Minor optimizations

  EgorBo

  committed
  2c851bc

  Copy full SHA for 2c851bc

• optimize cases with two-byte/two-char values

  EgorBo

  committed
  9308d82

  Copy full SHA for 9308d82

• Remove gotos, fix build

  EgorBo

  committed
  dac974a

  Copy full SHA for dac974a

• fix bug in LastIndexOf

  EgorBo

  committed
  3554ad3

  Copy full SHA for 3554ad3

• Make sure String.LastIndexOf is optimized

  EgorBo

  committed
  de87ec2

  Copy full SHA for de87ec2

Commits on Jan 13, 2022

• Merge branch 'main' of https://github.com/dotnet/runtime into vectorize-indexof

  EgorBo

  committed
  cb7541f

  Copy full SHA for cb7541f

• Use xplat simd helpers - implicit ARM support

  EgorBo

  committed
  b0b04ad

  Copy full SHA for b0b04ad

Commits on Jan 14, 2022

• fix arm

  EgorBo

  committed
  141e236

  Copy full SHA for 141e236

Commits on Jan 15, 2022

• Delete \

  EgorBo

  authored
  e664ad3

  Copy full SHA for e664ad3

• Use Vector128.IsHardwareAccelerated

  EgorBo

  committed
  bff8419

  Copy full SHA for bff8419

• Merge branch 'main' of https://github.com/dotnet/runtime into vectorize-indexof

  EgorBo

  committed
  dcc9d81

  Copy full SHA for dcc9d81

• Fix build

  EgorBo

  committed
  3def5e0

  Copy full SHA for 3def5e0

• Use IsAllZero

  EgorBo

  committed
  a52138b

  Copy full SHA for a52138b

• Address feedback

  EgorBo

  committed
  f86e323

  Copy full SHA for f86e323

• Address feedback

  EgorBo

  committed
  f2372a0

  Copy full SHA for f2372a0

• micro-optimization, do-while is better here since mask is guaranteed to be non-zero

  EgorBo

  committed
  38ef9a9

  Copy full SHA for 38ef9a9

Commits on Jan 17, 2022

• Merge branch 'main' of https://github.com/dotnet/runtime into vectorize-indexof

  EgorBo

  committed
  f5e6192

  Copy full SHA for f5e6192

Commits on Jan 18, 2022

• Address feedabc

  EgorBo

  committed
  4827ddc

  Copy full SHA for 4827ddc

• Use clever trick I borrowed from IndexOfAny for trailing elements

  EgorBo

  committed
  d601351

  Copy full SHA for d601351

• give up on +1 bump for SequenceCompare

  EgorBo

  committed
  3a005bc

  Copy full SHA for 3a005bc

• Clean up

  EgorBo

  committed
  9fefe81

  Copy full SHA for 9fefe81

• Clean up

  EgorBo

  committed
  c118dd2

  Copy full SHA for c118dd2

• fix build

  EgorBo

  committed
  7e8b100

  Copy full SHA for 7e8b100

Commits on Jan 21, 2022

• Merge branch 'main' of github.com:dotnet/runtime into vectorize-indexof

  EgorBo

  committed
  d805701

  Copy full SHA for d805701

• Merge branch 'main' of https://github.com/dotnet/runtime into vectorize-indexof

  EgorBo

  committed
  3bb56f0

  Copy full SHA for 3bb56f0

Commits on Jan 22, 2022

• Add debug asserts

  EgorBo

  committed
  e9df891

  Copy full SHA for e9df891

• Clean up: give up on the unrolled trick - too little value from code bloat

  EgorBo

  committed
  cb60535

  Copy full SHA for cb60535

• Add a test

  EgorBo

  committed
  7c55951

  Copy full SHA for 7c55951

• Fix build

  EgorBo

  committed
  3f0b4c3

  Copy full SHA for 3f0b4c3

Commits on Jan 24, 2022

• Merge branch 'main' of https://github.com/dotnet/runtime into vectorize-indexof

  EgorBo

  committed
  4d860a1

  Copy full SHA for 4d860a1

• Add byte-specific test

  EgorBo

  committed
  48f4fc7

  Copy full SHA for 48f4fc7

Commits on Jan 25, 2022

• Fix build

  EgorBo

  committed
  7c3b834

  Copy full SHA for 7c3b834

• Update IndexOfSequence.byte.cs

  EgorBo

  authored
  c68a07a

  Copy full SHA for c68a07a