Implement operator delete on ThreadStressLog #64478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
cshung
force-pushed
the
public/stress-delete
branch
from
6e9a4bb to
c74c596
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On rare occasions, we do delete
ThreadStressLogobjects here. We have to be fairly unlucky when that happens, but it is annoying enough when they become false positive when we wanted to reproduce a stress bug.If we do not override the delete operator, it will use this implementation of the delete operator and hit this assertion.
This change simply leaks the object when we are allocating from the memory-mapped file. I think that is okay given this condition should not happen often.