-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix build for musl 1.2.3 #67772
fix build for musl 1.2.3 #67772
Conversation
fa618b3
to
3e0362a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it locally on macOS, this fixes the innerloop build.
3e0362a
to
dfbe4d5
Compare
@am11 Perfect, that did it. I'm seeing success on Alpine pipelines. Many thanks! |
@ayakael, thanks for adding musl-libc v1.2.3 support early in its lifecycle! 👍 One unique thing about CoreCLR PAL is that it is essentially implementing Windows APIs on Unix, which rest of the code under The way palinternal is written is it undefines then redefines the low level functions (like those belonging to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo the two nits.
@ayakael thank you for the fix! |
dfbe4d5
to
f78b63b
Compare
you're welcome ^^
many thanks for sharing what PAL is for ^^ Being a packager first, programmer after, means that I mostly throw spaguetti at a wall to see if it sticks. It's nice to be able to have a background understanding on why things are as they are. |
this pull request (https://gitlab.alpinelinux.org/alpine/aports/-/commit/2f56551abc53b818bab9f22c4f7972b5ad5aad66 , just missing the two nits) applied onto our alpine build fixed it, and it works again :) (just notifying, since it was alpine that ran into this first) |
Many thanks, I had forgot to update (for the two nits - next update since they are just comments) |
Fixes #67763