Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MemoryExtensions.CommonPrefixLength #67929

Merged
merged 3 commits into from
Apr 17, 2022
Merged

Add MemoryExtensions.CommonPrefixLength #67929

merged 3 commits into from
Apr 17, 2022

Conversation

stephentoub
Copy link
Member

Fixes #64271

@ghost ghost assigned stephentoub Apr 12, 2022
@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Apr 12, 2022

Tagging subscribers to this area: @dotnet/area-system-memory
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #64271

Author: stephentoub
Assignees: stephentoub
Labels:

area-System.Memory, new-api-needs-documentation
Milestone: -

@runfoapp runfoapp bot mentioned this pull request Apr 13, 2022
Closed
adamsitnik
adamsitnik reviewed Apr 14, 2022
View reviewed changes
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stephentoub thank you! PTAL at my comments

src/libraries/System.Memory/tests/Span/CommonPrefixLength.T.cs Outdated Show resolved Hide resolved
src/libraries/System.Private.CoreLib/src/System/MemoryExtensions.cs Outdated Show resolved Hide resolved
src/libraries/System.Private.Xml/src/System/Xml/Core/XmlTextReaderImpl.cs Outdated Show resolved Hide resolved
src/libraries/System.Text.RegularExpressions/gen/Stubs.cs Show resolved Hide resolved
@stephentoub stephentoub merged commit 6cdb63a into dotnet:main Apr 17, 2022
@stephentoub stephentoub deleted the commonprefixlength branch April 17, 2022 20:26
@gfoidl gfoidl mentioned this pull request Apr 19, 2022
Merged
@dakersnar
Copy link
Contributor

I'm uncertain, but this might be the cause of this memory-related regression on Windows x86: dotnet/perf-autofiling-issues#4708

@stephentoub
Copy link
Member Author

I'm uncertain, but this might be the cause of this memory-related regression on Windows x86: dotnet/perf-autofiling-issues#4708

Very unlikely, as this just added a new method, and while it was used in a few places, none are related to that benchmark. Also, looking at the current graph, it seems like there were some wild fluctustions but then things went back to normal?

@ghost ghost locked as resolved and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GrabYourPitchforks GrabYourPitchforks GrabYourPitchforks left review comments

@terrajobst terrajobst terrajobst left review comments

@gfoidl gfoidl gfoidl left review comments

@adamsitnik adamsitnik adamsitnik left review comments

Assignees

@stephentoub stephentoub

Labels
area-System.Memory new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[API Proposal]: MemoryExtensions.CommonPrefixLength<T>
6 participants
@stephentoub @dakersnar @GrabYourPitchforks @terrajobst @gfoidl @adamsitnik