-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix placeholder files in packages #67960
Conversation
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsReported in #67647 (comment). Accidentally got the package path wrong for placeholder files and didn't notice it locally.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the quick fix. Should we fix these instances as well: % git grep 'PackagePath.*targets"'
eng/packaging.targets: <Content Include="$(MultiTargetRoslynComponentTargetsFileIntermediatePath)" PackagePath="buildTransitive\netstandard2.0\$(PackageId).targets" />
eng/packaging.targets: <Content Include="$(MultiTargetRoslynComponentTargetsFileIntermediatePath)" PackagePath="buildTransitive\%(NETStandardCompatError.Supported)\$(PackageId).targets" Condition="'@(NETStandardCompatError)' != ''" />
eng/packaging.targets: PackagePath="buildTransitive\%(NETStandardCompatError.Identity)\$(PackageId).targets"
eng/packaging.targets: PackagePath="$(_NETStandardCompatErrorPlaceholderFilePackagePath)\$(PackageId).targets"
src/libraries/System.Resources.Extensions/src/System.Resources.Extensions.csproj: PackagePath="buildTransitive\$(NetFrameworkMinimum)\$(PackageId).targets" /> Apparently |
I tested the packages and the cases that you pointed out work fine. I don't think there's anything to fix there. Can you please elaborate which kind of issues you are seeing? :) |
Cool. I just skimmed through #67647 diff and thought the other similar places (with filename in |
Reported in #67647 (comment). Accidentally got the package path wrong for placeholder files and didn't notice it locally.