Do not use '.NET Core' anymore in error messages #68260
Conversation
Added a test for a single-file FDD running over old hostfxr
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov Issue DetailsAdded a test for a single-file FDD running over old hostfxr In reaction to #67427.
|
src/installer/tests/Microsoft.NET.HostModel.Tests/AppHost.Bundle.Tests/BundledAppWithSubDirs.cs
Outdated
Show resolved
Hide resolved
Include apphost version, .NET location and so on. Similar to other improved error messages now.
|
@elinor-fung could you please take another look? I followed the same format as the other "improved" error messages. |
| { | ||
| pal::string_t url = get_download_url(); | ||
| trace::error(_X(" _ To run this application, you need to install a newer version of .NET Core.")); |
There was a problem hiding this comment.
Can we get rid of the check for the _ prefix now?
There was a problem hiding this comment.
Isn't it necessary for the pre 7.0 runtimes?
7.0 doesn't use it anymore, but the apphost still needs to work downlevel for some rather weird cases.
There was a problem hiding this comment.
I thought apphost itself was the only thing actually writing with that prefix? Because with downlevel hostfxr, we couldn't actually redirect the errors from hostfxr.
There was a problem hiding this comment.
What about 7.0 apphost running against 6.0 hostfxr - the hostfxr might still use the _ prefix somewhere (I didn't check). In that case the error info will be redirected from hostfxr to apphost and if it contains _ it should be parsed.
There was a problem hiding this comment.
I was pretty sure we only ever used it for apphost, but I didn't actually go back and check.
Either way, the UX and changes you have right now look good to me.
There was a problem hiding this comment.
I just searched 3.1 and it only uses the prefix in apphost - but I'm still nervous about doing this. Honestly I would rather keep it.
It now includes the apphost version and architecture, just like we do if there's no runtime at all. Also some PR feedback fixes.
|
I improved the dialog for the case of old runtime, it now looks very similar to the case where there's no runtime at all. Most notably it contains apphost version and architecture: |
ghost
locked as resolved and limited conversation to collaborators
Added a test for a single-file FDD running over old hostfxr
In reaction to #67427.