[wasm] Misc debugger improvements #68988
Conversation
.. from `DebuggerTestSuite.csproj`. This will allow other projects to use this too.
so it can be used outside the debugger tests project too. For example, with Wasm.Build.Tests+playwright .
.. using `ExceptionDispatchInfo.Capture` so we get the original stack trace.
- like logging - updated API to make it easier to use by other projects, like the upcoming wasm-app-host .
.. on the first line of the entrypoint method (`Main`). This will be useful for debugging with the upcoming wasm-app-host, along with the use of `wait-for-debugger`. Implemented by @thaystg .
If requested, then it will cause invocation of `main` to be delayed till a debugger is attached. Implemented by @thaystg
.. in the lead up to wasm-app-host tests.
.. to include templates, and provisioning props.
ghost
assigned 
|
Tagging subscribers to 'arch-wasm': @lewing Issue Details
Extracted from #68696
|
.. project name, instead of always creating `browser.dll`, and `console.dll`.
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
cc @radekdoulik I added some minimal |
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
wasm/AOT failure is NRE in linker: dotnet/linker#2789 |
.. as recommended by the documentation.
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| // FIXME: id | ||
| string bpId = "bp://99999"; |
There was a problem hiding this comment.
do we do anything specific with the bp id format? If we're making one up can't we do something a little more obvious?
| public MethodInfo FindEntryPoint() | ||
| { | ||
| if (_entryPoint is null) | ||
| _entryPoint = assemblies.Where(asm => asm.EntryPoint is not null).Select(asm => asm.EntryPoint).FirstOrDefault(); |
There was a problem hiding this comment.
is assemblies guaranteed to be in the correct order for this to work?
There was a problem hiding this comment.
The assumption here is that there will be only one assembly with an entry point. If not, then yeah, the order would matter.
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Chrome debugger tests are passing. |
Extracted from #68696
Added by @thaystg:
--wait-for-debugger- If requested, then it will cause invocation ofmainto be delayed till a debugger is attached.Main). This will beuseful for debugging with the upcoming wasm-app-host, along with the use of
wait-for-debugger.