Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from dotnet/hotreload-utils #69131

Merged
merged 1 commit into from
May 11, 2022
Merged

[main] Update dependencies from dotnet/hotreload-utils #69131

merged 1 commit into from
May 11, 2022

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented May 10, 2022 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/hotreload-utils

  • Subscription: bfe6dacf-8231-4ea1-e2fe-08d962847885
  • Build: 20220509.2
  • Date Produced: May 9, 2022 3:09:58 PM UTC
  • Commit: d9dcc60a194a94a89fa1e31d6b2bf7dec9b1d92f
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/hotreload-utils bu…
0581db5 
…ild 20220509.2

Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
 From Version 1.1.0-alpha.0.22252.2 -> To Version 1.1.0-alpha.0.22259.2
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow label May 10, 2022
@am11
Copy link
Member

am11 commented May 10, 2022

@lambdageek, just curious, why is hotreload generator under a dedicated repo? We have several, very different, kinds of generators in the runtime monorepo and they are continuously growing.

@lewing
Copy link
Member

lewing commented May 11, 2022 •
edited
Loading

MemoryMappedFiles Failure is known and fixed #69136

The other failure looked like a helix problem, rerunning

@lambdageek
Copy link
Member

@lambdageek, just curious, why is hotreload generator under a dedicated repo? We have several, very different, kinds of generators in the runtime monorepo and they are continuously growing.

hotreload-utils at one point was picking up Roslyn dependencies daily from one of their faster branches because they were doing EnC changes and I wanted to isolate the runtime from that. (also i'm not sure if we can have two roslyn feeds going into the main branch of dotnet/runtime)

At this point there are not many relevant changes in Roslyn, and hotreload-utils is getting only weekly updates from there. So it might make sense to move it here. I'm not opposed, but I'm not really motivated to do it myself.

@lambdageek lambdageek merged commit 3f9c1ad into main May 11, 2022
@dotnet-maestro dotnet-maestro bot deleted the darc-main-1e4fd5af-4674-4109-b92f-e7f6f14bddc4 branch May 11, 2022 14:02
@ghost ghost locked as resolved and limited conversation to collaborators Jun 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lambdageek lambdageek lambdageek approved these changes

Assignees
No one assigned
Labels
area-codeflow for labeling automated codeflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@am11 @lewing @lambdageek