Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Wbitwise-instead-of-logical in native tests #72313

Merged
merged 1 commit into from
Jul 16, 2022

Conversation

am11
Copy link
Member

@am11 am11 commented Jul 16, 2022

Running src/tests/build.sh with clang 15 was raising an error Wbitwise-instead-of-logical on line 391 due to the use of & instead of && in if condition.

Also cleaned up trailing whitespaces from this file while at it.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jul 16, 2022
@ghost
Copy link

ghost commented Jul 16, 2022

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Running src/tests/build.sh with clang 15 was raising an error Wbitwise-instead-of-logical on line 391 due to the use of & instead of && in if condition.

Also cleaned up trailing whitespaces from this file while at it.

Author: am11
Assignees: -
Labels:

area-Infrastructure, community-contribution

Milestone: -

@am11 am11 requested a review from janvorli July 16, 2022 10:00
@jkotas jkotas merged commit cc75427 into dotnet:main Jul 16, 2022
@am11 am11 deleted the feature/build/native branch July 24, 2022 07:29
@ghost ghost locked as resolved and limited conversation to collaborators Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants