Always generate metadata for dynamic methods

[davmason]

Fixes #62977

This is an unintended side effect of #57069. As it stands now we won't generate metadata for dynamic modules unless a debugger is attached. Before that change we would bail from ReflectionModule::CaptureModuleMetaDataToMemory only if IsMetadataCaptureSuppressed() && !CORDebuggerAttached(), IsMetadataCaptureSuppressed() was only true in one case, when we were importing a COM type lib. But, when the import was done it would turn suppression off and we would generate the metadata then.

runtime/src/coreclr/vm/ceeload.cpp

Lines 12688 to 12691 in 3dc99e9

	if (IsMetadataCaptureSuppressed() && !CORDebuggerAttached())
	{
	return;
	}

After the change we always bail unconditionally if no debugger is attached, and there is no code to update it when a debugger attaches later.

runtime/src/coreclr/vm/ceeload.cpp

Lines 4774 to 4777 in 50fa756

	if (!CORDebuggerAttached())
	{
	return;
	}

The fix here is to delete the early out, since the COM typelib code was removed as part of the same effort. This will revert us to the previous behavior.

Originally posted by @davmason in #62977 (comment)

[ghost]

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Fixes #62977

This is an unintended side effect of #57069. As it stands now we won't generate metadata for dynamic modules unless a debugger is attached. Before that change we would bail from ReflectionModule::CaptureModuleMetaDataToMemory only if IsMetadataCaptureSuppressed() && !CORDebuggerAttached(), IsMetadataCaptureSuppressed() was only true in one case, when we were importing a COM type lib. But, when the import was done it would turn suppression off and we would generate the metadata then.

runtime/src/coreclr/vm/ceeload.cpp

Lines 12688 to 12691 in 3dc99e9

	if (IsMetadataCaptureSuppressed() && !CORDebuggerAttached())
	{
	return;
	}

After the change we always bail unconditionally if no debugger is attached, and there is no code to update it when a debugger attaches later.

runtime/src/coreclr/vm/ceeload.cpp

Lines 4774 to 4777 in 50fa756

	if (!CORDebuggerAttached())
	{
	return;
	}

The fix here is to delete the early out, since the COM typelib code was removed as part of the same effort. This will revert us to the previous behavior.

Originally posted by @davmason in #62977 (comment)

Author:	davmason
Assignees:	davmason
Labels:	area-Diagnostics-coreclr
Milestone:	7.0.0

[jkotas]

Thank you for fixing this!