Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Disable GetGCMemoryInfo on arm (#73477)" #73595

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

noahfalk
Copy link
Member

@noahfalk noahfalk commented Aug 8, 2022

Fixes #73247

This reverts commit 9865cc7.
We believe the problematic change has been reverted so the test can be re-enabled.

This reverts commit 9865cc7.
We believe the problematic change has been reverted so the test can be re-enabled.
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost assigned noahfalk Aug 8, 2022
@noahfalk
Copy link
Member Author

noahfalk commented Aug 8, 2022

@am11 @filipnavara @janvorli @jkoritzinsky @karelz

@noahfalk
Copy link
Member Author

noahfalk commented Aug 8, 2022

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@noahfalk
Copy link
Member Author

noahfalk commented Aug 8, 2022

@karelz - as new test-monitor can I hand this PR over to you to decide whether or not to merge it? I think the PR that reverted the pinvoke inlining did its ARM validation before this test got disabled and passed so I am reasonably confident that issue is solved. This PR just gets the test turned on again and confirms everything is still in good shape.

@noahfalk noahfalk assigned karelz and akoeplinger and unassigned noahfalk and karelz Aug 8, 2022
@filipnavara
Copy link
Member

Some of the pipelines unfortunately failed on the dotnet-install.sh script where HTML was received from the server instead of expected binary data...

@noahfalk noahfalk assigned karelz and unassigned akoeplinger Aug 9, 2022
@akoeplinger
Copy link
Member

I retried the failing jobs, let's see.

@hoyosjs
Copy link
Member

hoyosjs commented Aug 9, 2022

The Android JIT.Directed failures are tracked in #73539

@karelz
Copy link
Member

karelz commented Aug 10, 2022

@noahfalk sorry for late response, I didn't notice it until now.
I was a bit lost what reverted what and fixed what -- I updated the top post.

@ghost ghost locked as resolved and limited conversation to collaborators Sep 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GC/API/GC/GetGCMemoryInfo/GetGCMemoryInfo.sh test failing intermittently on CoreCLR Linux ARM32
6 participants