Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/6.0] Don't lookup the pack without an alias from the workload #74155

Merged
merged 1 commit into from
Aug 18, 2022
Merged

[release/6.0] Don't lookup the pack without an alias from the workload #74155

merged 1 commit into from
Aug 18, 2022

Conversation

lewing
Copy link
Member

@lewing lewing commented Aug 18, 2022

This doesn't work with aliasing

@lewing lewing requested a review from marek-safar as a code owner August 18, 2022 15:58
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost assigned lewing Aug 18, 2022
jonathanpeppers
jonathanpeppers approved these changes Aug 18, 2022
View reviewed changes
Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this locally building this branch: dotnet/android#7265

Then locally this change:

<LatestRuntimeFrameworkVersion Condition="'%(KnownRuntimePack.TargetFramework)' == 'net6.0' and '%(KnownRuntimePack.RuntimePackLabels)' == 'Mono'">6.0.9</LatestRuntimeFrameworkVersion>

Allows Android projects to be able to restore again.

Previously, I was hitting:

Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(90,5): error : NETSDKZZZZ: Error getting pack version: Pack 'Microsoft.NETCore.App.Runtime.Mono.android-arm' was not present in workload manifests.
Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(90,5): error : NETSDKZZZZ: Error getting pack version: Pack 'Microsoft.NETCore.App.Runtime.Mono.android-arm64' was not present in workload manifests.
Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(90,5): error : NETSDKZZZZ: Error getting pack version: Pack 'Microsoft.NETCore.App.Runtime.Mono.android-x86' was not present in workload manifests.
Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(90,5): error : NETSDKZZZZ: Error getting pack version: Pack 'Microsoft.NETCore.App.Runtime.Mono.android-x64' was not present in workload manifests.

@lewing lewing mentioned this pull request Aug 18, 2022
Closed
@lewing lewing requested a review from jeffschwMSFT August 18, 2022 16:37
@lewing lewing added the Servicing-consider Issue for next servicing release review label Aug 18, 2022
@lewing lewing added this to the 6.0.x milestone Aug 18, 2022
@lewing lewing requested a review from mmitche August 18, 2022 16:37
jeffschwMSFT
jeffschwMSFT approved these changes Aug 18, 2022
View reviewed changes
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. Adding @carlossanlop to know when to merge.

@ghost
Copy link

ghost commented Aug 18, 2022

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

This doesn't work with aliasing

Author: lewing
Assignees: lewing
Labels:

Servicing-consider, area-Infrastructure-mono
Milestone: 6.0.x

@leecow leecow added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Aug 18, 2022
@leecow leecow modified the milestones: 6.0.x, 6.0.9 Aug 18, 2022
@marcpopMSFT marcpopMSFT mentioned this pull request Aug 18, 2022
Closed
@lewing
Copy link
Member Author

lewing commented Aug 18, 2022

@carlossanlop the failure has nothing to do with the change, can we merge this asap?

@carlossanlop
Copy link
Member

@lewing we are past code complete for September servicing. Let me ask if there is still runway. Otherwise, this will have to wait until next month.

@lewing
Copy link
Member Author

lewing commented Aug 18, 2022

This is blocking 6.0.9

@carlossanlop
Copy link
Member

Thanks for the clarification. Merging now.

@carlossanlop carlossanlop merged commit 21ab9a9 into dotnet:release/6.0 Aug 18, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dsplaisted dsplaisted dsplaisted approved these changes

@jonathanpeppers jonathanpeppers jonathanpeppers approved these changes

@jeffschwMSFT jeffschwMSFT jeffschwMSFT approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar marek-safar is a code owner

@marcpopMSFT marcpopMSFT Awaiting requested review from marcpopMSFT

@mmitche mmitche Awaiting requested review from mmitche

Assignees

@lewing lewing

Labels
area-Infrastructure-mono Servicing-approved Approved for servicing release
Projects
None yet
Milestone
6.0.9
Development

Successfully merging this pull request may close these issues.
7 participants
@lewing @carlossanlop @dsplaisted @jonathanpeppers @jeffschwMSFT @leecow @danmoseley