Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPMI: Write out improvements/regressions breakdown details #76711

Merged
merged 5 commits into from
Oct 6, 2022
Merged

SPMI: Write out improvements/regressions breakdown details #76711

merged 5 commits into from
Oct 6, 2022

Conversation

jakobbotsch
Copy link
Member

@jakobbotsch jakobbotsch commented Oct 6, 2022 •
edited
Loading

Write out a breakdown of improvements/regressions to be able to gauge better how the improvements stack up against the regressions.

Contributes to #75848

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 6, 2022
@ghost ghost assigned jakobbotsch Oct 6, 2022
@ghost
Copy link

ghost commented Oct 6, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: jakobbotsch
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@jakobbotsch jakobbotsch mentioned this pull request Oct 6, 2022
Closed
@jakobbotsch
Copy link
Member Author

cc @dotnet/jit-contrib PTAL @AndyAyersMS

This is how it looks (first table under 'Details'): https://dev.azure.com/dnceng-public/public/_build/results?buildId=42913&view=ms.vss-build-web.run-extensions-tab

I will of course make sure to revert the JIT change before merging.

AndyAyersMS
AndyAyersMS approved these changes Oct 6, 2022
View reviewed changes
Copy link
Member

@AndyAyersMS AndyAyersMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks -- I think this will be quite helpful in understanding the diffs.

@jakobbotsch jakobbotsch merged commit 0a72868 into dotnet:main Oct 6, 2022
@jakobbotsch jakobbotsch deleted the improvements-regressions-spmi-asmdiff branch October 6, 2022 20:24
@BruceForstall
Copy link
Member

Really great work!

However, the replay_with_asm_diffs function is getting ridiculous. We need to refactor it into separate functions.

@jakobbotsch
Copy link
Member Author

However, the replay_with_asm_diffs function is getting ridiculous. We need to refactor it into separate functions.

You're right. I will keep in mind to do a little refactoring as part of my future PRs.

@ghost ghost locked as resolved and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndyAyersMS AndyAyersMS AndyAyersMS approved these changes

Assignees

@jakobbotsch jakobbotsch

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakobbotsch @BruceForstall @AndyAyersMS