-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use FIELD_ADDR
for all ldflda
s
#78226
Use FIELD_ADDR
for all ldflda
s
#78226
Conversation
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsI. e. add support for when the underlying address is local. We're expecting a small number of improvements due to:
There are also some regressions in CoreCLR tests where we stop promoting locals with SIMD fields because
|
e509aa0
to
8488f42
Compare
297dc69
to
3c30da1
Compare
31c6185
to
a82cce8
Compare
@dotnet/jit-contrib |
@SingleAccretion can you post the link to the diff once it's ready, I see that previous diffs no longer available |
Yes, will do. |
Diffs have been obtained and still look like the ones in the description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice TP wins!
I. e. add support for when the underlying address is local.
Diffs.
A small number of improvements due to:
There are also some regressions in CoreCLR tests where we stop promoting locals with SIMD fields because
FIELD_ADDR
s don't resolve SIMD type handles. I think it is good TP tradeoff to keep it like that, considering the regressions are test-only and in non-test collections this leads to improvements.There is also a nice TP win (~
0.3
%).Fixes #77636.