Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FIELD_ADDR for all ldfldas #78226

Merged
merged 11 commits into from
Nov 29, 2022

Conversation

SingleAccretion
Copy link
Contributor

@SingleAccretion SingleAccretion commented Nov 11, 2022

I. e. add support for when the underlying address is local.

Diffs.

A small number of improvements due to:

  1. Minor CSE changes.
  2. Less aggressive promotion of implicit byrefs.

There are also some regressions in CoreCLR tests where we stop promoting locals with SIMD fields because FIELD_ADDRs don't resolve SIMD type handles. I think it is good TP tradeoff to keep it like that, considering the regressions are test-only and in non-test collections this leads to improvements.

There is also a nice TP win (~0.3%).

Fixes #77636.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Nov 11, 2022
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 11, 2022
@ghost
Copy link

ghost commented Nov 11, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

I. e. add support for when the underlying address is local.

We're expecting a small number of improvements due to:

  1. Minor CSE changes.
  2. Less aggressive promotion of implicit byrefs.

There are also some regressions in CoreCLR tests where we stop promoting locals with SIMD fields because FIELD_ADDRs don't resolve SIMD type handles. I think it is good TP tradeoff to keep it like that, considering the regressions are test-only and in non-test collections this leads to improvements.

Author: SingleAccretion
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution

Milestone: -

@SingleAccretion SingleAccretion force-pushed the Field-Addr-Local-Upstream branch from e509aa0 to 8488f42 Compare November 11, 2022 15:54
@SingleAccretion SingleAccretion force-pushed the Field-Addr-Local-Upstream branch 2 times, most recently from 297dc69 to 3c30da1 Compare November 11, 2022 19:23
@SingleAccretion SingleAccretion force-pushed the Field-Addr-Local-Upstream branch from 31c6185 to a82cce8 Compare November 11, 2022 19:47
@SingleAccretion SingleAccretion marked this pull request as ready for review November 11, 2022 22:54
@SingleAccretion
Copy link
Contributor Author

@dotnet/jit-contrib

@EgorBo
Copy link
Member

EgorBo commented Nov 28, 2022

@SingleAccretion can you post the link to the diff once it's ready, I see that previous diffs no longer available

@SingleAccretion
Copy link
Contributor Author

Yes, will do.

@SingleAccretion
Copy link
Contributor Author

Diffs have been obtained and still look like the ones in the description.

Copy link
Member

@EgorBo EgorBo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice TP wins!

@EgorBo EgorBo merged commit 05c6c42 into dotnet:main Nov 29, 2022
@SingleAccretion SingleAccretion deleted the Field-Addr-Local-Upstream branch November 29, 2022 18:11
@ghost ghost locked as resolved and limited conversation to collaborators Dec 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Jit doesn't handle certain uses of field addresses correctly
2 participants