Stop producing and handling ADDR nodes
#78246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsMostly just dead code and cases where we can use Some positive diffs are expected from the MD array import change.
|
Closed
SingleAccretion
force-pushed
the
No-Addr-Node-Misc
branch
2 times, most recently
from
8d332c6 to
bcef6eb
Compare
SingleAccretion
commented
Nov 12, 2022
SingleAccretion
force-pushed
the
No-Addr-Node-Misc
branch
2 times, most recently
from
d0d8618 to
bcef6eb
Compare
SingleAccretion
force-pushed
the
No-Addr-Node-Misc
branch
from
f792610 to
99c19dd
Compare
SingleAccretion
changed the title
ADDR-related codeADDR nodes
SingleAccretion
changed the title
ADDR nodesADDR nodes
SingleAccretion
force-pushed
the
No-Addr-Node-Misc
branch
2 times, most recently
from
d09f03c to
5b22300
Compare
SingleAccretion
force-pushed
the
No-Addr-Node-Misc
branch
2 times, most recently
from
ca22141 to
e62d5fc
Compare
SingleAccretion
force-pushed
the
No-Addr-Node-Misc
branch
from
e62d5fc to
71b97d0
Compare
|
@dotnet/jit-contrib We are getting eerily close to |
drieseng
reviewed
Dec 10, 2022
|
/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress |
|
Azure Pipelines successfully started running 2 pipeline(s). |
BruceForstall
approved these changes
Dec 14, 2022
|
libraries-jitstress had a few failures: one known, one looked like infra, Linux/arm tailcallstress had a "new" crash in System.Memory.Tests. Set to rerun to see if it repros. |
|
Didn't repro; all failures are "known". |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, the
GT_ADDRoper (for a short time before its eventual deletion) becomes "synthetic": no actual nodes of it will be created.We also start using local address nodes in more places and delete dead code.
Diffs: minor GC info size reductions (
LCL_VAR_ADDRs are typedI_IMPL); some substitution diffs (due to fewerGLOB_REFs).There are nice TP improvements:
0.3%on 64 bit platforms,1%on 32 bit platforms, of which the latter comes mostly from theOperIsIndirfix.