Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PERF] Fix mono dotnet creation #78257

Merged
merged 10 commits into from
Nov 15, 2022

Conversation

LoopedBard3
Copy link
Member

The create mono dotnet job is failing due to mismatches in the command line used, this fixes that. Here is a test run with the changes to the mono dotnet job: https://dev.azure.com/dnceng/internal/_build/results?buildId=2043117&view=results. This fixes dotnet/performance#2719 for main.

The current reason for this problem seems to be that main is still using net7.0 sdk versions and net7.0 targetting in the build-job.yml for building coreclr and libraries. While what we run is still main, some of the names of the items mismatch, and in this case that is net7.0 being in the bin output instead of net8.0.

@ghost
Copy link

ghost commented Nov 11, 2022

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

The create mono dotnet job is failing due to mismatches in the command line used, this fixes that. Here is a test run with the changes to the mono dotnet job: https://dev.azure.com/dnceng/internal/_build/results?buildId=2043117&view=results. This fixes dotnet/performance#2719 for main.

The current reason for this problem seems to be that main is still using net7.0 sdk versions and net7.0 targetting in the build-job.yml for building coreclr and libraries. While what we run is still main, some of the names of the items mismatch, and in this case that is net7.0 being in the bin output instead of net8.0.

Author: LoopedBard3
Assignees: LoopedBard3
Labels:

area-Infrastructure-coreclr

Milestone: -

@LoopedBard3 LoopedBard3 marked this pull request as draft November 11, 2022 23:43
Copy link
Contributor

@cincuranet cincuranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in commands LGTM.

@LoopedBard3
Copy link
Member Author

Successful perf pipeline testing run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2045192&view=results

@LoopedBard3 LoopedBard3 marked this pull request as ready for review November 15, 2022 07:07
@cincuranet cincuranet merged commit 1a476d7 into dotnet:main Nov 15, 2022
@cincuranet
Copy link
Contributor

Pipeline is green. Merging per @LoopedBard3's request.

@LoopedBard3 LoopedBard3 deleted the PerfFixMonoDotnetCreation branch November 15, 2022 16:32
@ghost ghost locked as resolved and limited conversation to collaborators Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mono dotnet creation failing, failing micro_mono runs
2 participants