-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PERF] Fix mono dotnet creation #78257
[PERF] Fix mono dotnet creation #78257
Conversation
Tagging subscribers to this area: @hoyosjs Issue DetailsThe create mono dotnet job is failing due to mismatches in the command line used, this fixes that. Here is a test run with the changes to the mono dotnet job: https://dev.azure.com/dnceng/internal/_build/results?buildId=2043117&view=results. This fixes dotnet/performance#2719 for main. The current reason for this problem seems to be that main is still using net7.0 sdk versions and net7.0 targetting in the build-job.yml for building coreclr and libraries. While what we run is still main, some of the names of the items mismatch, and in this case that is net7.0 being in the bin output instead of net8.0.
|
This reverts commit 74c8fd3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in commands LGTM.
…ues do currently need to be hardcoded.
Successful perf pipeline testing run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2045192&view=results |
This reverts commit d7e941e.
Pipeline is green. Merging per @LoopedBard3's request. |
The create mono dotnet job is failing due to mismatches in the command line used, this fixes that. Here is a test run with the changes to the mono dotnet job: https://dev.azure.com/dnceng/internal/_build/results?buildId=2043117&view=results. This fixes dotnet/performance#2719 for main.
The current reason for this problem seems to be that main is still using net7.0 sdk versions and net7.0 targetting in the build-job.yml for building coreclr and libraries. While what we run is still main, some of the names of the items mismatch, and in this case that is net7.0 being in the bin output instead of net8.0.