Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix XxHash3/XxHash128 DeriveSecretFromSeed scalar fallback on big endian #79186

Merged
merged 1 commit into from
Dec 3, 2022

Conversation

xoofx
Copy link
Member

@xoofx xoofx commented Dec 3, 2022

This is a backport of #78084 to fix a regression on big-endian platform (see this comment)

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Dec 3, 2022
@ghost
Copy link

ghost commented Dec 3, 2022

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

This is a backport of #78084 to fix a regression on big-endian platform (see this comment)

Author: xoofx
Assignees: -
Labels:

area-System.IO, community-contribution

Milestone: -

@xoofx xoofx mentioned this pull request Dec 3, 2022
@xoofx xoofx closed this Dec 3, 2022
@xoofx xoofx reopened this Dec 3, 2022
@stephentoub stephentoub merged commit 4ce23f4 into dotnet:main Dec 3, 2022
@uweigand
Copy link
Contributor

uweigand commented Dec 4, 2022

Thanks @xoofx and @stephentoub for the quick fix! The runtime-community CI is now all green again.

@ghost ghost locked as resolved and limited conversation to collaborators Jan 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.IO community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants