Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all of generic virtual method resolution to the type loader #79925

Merged
merged 2 commits into from
Dec 23, 2022

Conversation

MichalStrehovsky
Copy link
Member

For whatever reason, the logic that walks the inheritance hierarchy and deals with the differences between interface GVM and class GVM calls was in CoreLib.

Move it to the type loader because we'll need it for #77070.

This is just a mechanical change - copy paste the code to the new location and adapt so that it builds.

Cc @dotnet/ilc-contrib

For whatever reason, the logic that walks the inheritance hierarchy and deals with the differences between interface GVM and class GVM calls was in CoreLib.

Move it to the type loader because we'll need it for dotnet#77070.
@ghost
Copy link

ghost commented Dec 23, 2022

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

For whatever reason, the logic that walks the inheritance hierarchy and deals with the differences between interface GVM and class GVM calls was in CoreLib.

Move it to the type loader because we'll need it for #77070.

This is just a mechanical change - copy paste the code to the new location and adapt so that it builds.

Cc @dotnet/ilc-contrib

Author: MichalStrehovsky
Assignees: -
Labels:

area-NativeAOT-coreclr

Milestone: -

@jkotas jkotas merged commit 5b99dce into dotnet:main Dec 23, 2022
@MichalStrehovsky MichalStrehovsky deleted the moveresolve branch December 25, 2022 05:05
@ghost ghost locked as resolved and limited conversation to collaborators Jan 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants