Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPMI: Indent details sections via CSS #82375

Merged
merged 21 commits into from
Feb 21, 2023

Conversation

jakobbotsch
Copy link
Member

@jakobbotsch jakobbotsch commented Feb 20, 2023

Adds indentation to each "details" section in the SPMI summary so that it is easier to understand the hierarchical structure. Example.

jakobbotsch and others added 11 commits February 19, 2023 13:24
This adds up to 3 improvement and 3 regression example diffs to the
markdown summary for each collection. The examples are picked to be the
highest percentage wise improvements and regressions with a limit on the
total size of the diff to avoid too much text in the diffs.
@ghost ghost assigned jakobbotsch Feb 20, 2023
@jakobbotsch
Copy link
Member Author

jakobbotsch commented Feb 20, 2023

How it looks (from diffs):
image

Will wait for #82364 first.

@jakobbotsch jakobbotsch marked this pull request as ready for review February 20, 2023 23:09
@jakobbotsch
Copy link
Member Author

PTAL @dotnet/jit-contrib. Easiest to review with hidden whitespace.

Copy link
Member

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

@jakobbotsch jakobbotsch merged commit f6bed51 into dotnet:main Feb 21, 2023
@jakobbotsch jakobbotsch deleted the spmi-indent-details-summary branch February 21, 2023 08:58
@ghost ghost locked as resolved and limited conversation to collaborators Mar 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants