-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPMI: Indent details sections via CSS #82375
Merged
jakobbotsch
merged 21 commits into
dotnet:main
from
jakobbotsch:spmi-indent-details-summary
Feb 21, 2023
Merged
SPMI: Indent details sections via CSS #82375
jakobbotsch
merged 21 commits into
dotnet:main
from
jakobbotsch:spmi-indent-details-summary
Feb 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds up to 3 improvement and 3 regression example diffs to the markdown summary for each collection. The examples are picked to be the highest percentage wise improvements and regressions with a limit on the total size of the diff to avoid too much text in the diffs.
Co-authored-by: Adeel Mujahid <[email protected]>
…nto spmi-example-diffs
PTAL @dotnet/jit-contrib. Easiest to review with hidden whitespace. |
BruceForstall
approved these changes
Feb 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds indentation to each "details" section in the SPMI summary so that it is easier to understand the hierarchical structure. Example.