-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QUIC] Fix failing parallel tests #83687
Conversation
Tagging subscribers to this area: @dotnet/ncl Issue DetailsFix failing parallel tests in S.N.Quic with pro-longing the cut-off time for queued operations in MsQuic, only in tests. Tested on arm machine where failures of
|
/azp list |
/azp run runtime-libraries-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-libraries-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-libraries-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
src/libraries/System.Net.Quic/tests/FunctionalTests/QuicTestBase.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Quic/tests/FunctionalTests/QuicTestBase.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/azp run runtime-libraries-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
Outerloop failures unrelated. |
Fix failing parallel tests in S.N.Quic with pro-longing the cut-off time for queued operations in MsQuic, only in tests.
Note that this against MsQuic recommendation, but since both client and server are on the same machine, in the same process, they are both "slow" the same way and this allows them to slowly deal with bursts of parallel requests.
Tested on arm machine where failures of
Listener_BacklogLimitRefusesConnection_ParallelClients_ClientThrows_Slow
were 100% reproducible. After the change, the test runs without any issues.Fixes #82769