Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ArgumentOutOfRangeException.ThrowIf{Not}Equal #83853

Merged
merged 4 commits into from
Apr 6, 2023
Merged

Add ArgumentOutOfRangeException.ThrowIf{Not}Equal #83853

merged 4 commits into from
Apr 6, 2023

Conversation

stephentoub
Copy link
Member

Fixes #82667

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost assigned stephentoub Mar 23, 2023
@stephentoub stephentoub changed the title Add AOORE.ThrowIf{Not}Equal Add ArgumentOutOfRangeException.ThrowIf{Not}Equal Mar 23, 2023
@build-analysis build-analysis bot mentioned this pull request Mar 24, 2023
Closed
@BrennanConroy BrennanConroy mentioned this pull request Apr 3, 2023
Merged
@surayya-MS surayya-MS mentioned this pull request Apr 4, 2023
Closed
buyaa-n
buyaa-n approved these changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

@stephentoub
Copy link
Member Author

Thanks.

@stephentoub stephentoub merged commit aca3fcc into dotnet:main Apr 6, 2023
@stephentoub stephentoub deleted the aoorethrowequal branch April 6, 2023 02:33
@build-analysis build-analysis bot mentioned this pull request Apr 6, 2023
Open
@xtqqczze
Copy link
Contributor

xtqqczze commented Apr 6, 2023

@stephentoub I've proposed ArgumentOutOfRangeException.ThrowIfNotZero (#84415).

@ghost ghost locked as resolved and limited conversation to collaborators May 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xtqqczze xtqqczze xtqqczze left review comments

@buyaa-n buyaa-n buyaa-n approved these changes

@jeffhandley jeffhandley jeffhandley approved these changes

Assignees

@stephentoub stephentoub

Labels
new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[API Proposal]: ArgumentOutOfRangeException.ThrowIfEqual and ThrowIfNotEqual
4 participants
@stephentoub @xtqqczze @jeffhandley @buyaa-n