Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split superpmi-diffs pipeline runs #84521

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Split superpmi-diffs pipeline runs #84521

merged 1 commit into from
Apr 11, 2023

Conversation

BruceForstall
Copy link
Member

Run tpdiffs and asmdiffs on separate Helix machines, in parallel, to improve overall job throughput.

@ghost ghost assigned BruceForstall Apr 8, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 8, 2023
@ghost
Copy link

ghost commented Apr 8, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak
See info in area-owners.md if you want to be subscribed.

Issue Details

Run tpdiffs and asmdiffs on separate Helix machines, in parallel, to improve overall job throughput.

Author: BruceForstall
Assignees: BruceForstall
Labels:

area-CodeGen-coreclr
Milestone: -

@BruceForstall
Copy link
Member Author

/azp run runtime-coreclr superpmi-diffs

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@BruceForstall
Split superpmi-diffs pipeline runs
ef5b02e 
Run tpdiffs and asmdiffs on separate Helix machines, in parallel,
to improve overall job throughput.
@BruceForstall BruceForstall marked this pull request as ready for review April 9, 2023 02:06
@BruceForstall
Copy link
Member Author

BruceForstall commented Apr 9, 2023 •
edited
Loading

Sample run: https://dev.azure.com/dnceng-public/public/_build/results?buildId=232648&view=results

Note the elapsed time of 1:15 versus previous times of 2:15 to 2:30.

@BruceForstall
Copy link
Member Author

@jakobbotsch PTAL
cc @dotnet/jit-contrib

@BruceForstall
Copy link
Member Author

Fixes #80718

(There are other ideas in that issue for additional parallelization work, but this is the "easy" fix that fixes the biggest time concern.)

@BruceForstall
Copy link
Member Author

I created a diff type of "all" that is untested (and unused) -- just in case we might want it someday -- that would allow the previous behavior of doing both asmdiffs/tpdiff on the same machine. This turns out to have been easy to do and almost "falls out".

@jakobbotsch
Copy link
Member

Nice!

@BruceForstall BruceForstall merged commit 4ebecb0 into dotnet:main Apr 11, 2023
@BruceForstall BruceForstall deleted the SplitAsmAndTpDiffs branch April 11, 2023 15:14
@ghost ghost locked as resolved and limited conversation to collaborators May 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jakobbotsch jakobbotsch jakobbotsch approved these changes

Assignees

@BruceForstall BruceForstall

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BruceForstall @jakobbotsch