[RISC-V][JIT] Fix assert on passing double in struct #84584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak Issue Detailscc @jakobbotsch @gbalykov @clamp03 @alpencolt
|
|
You need to run jit-format. https://github.com/dotnet/jitutils/blob/main/doc/formatting.md |
t-mustafin
force-pushed
the
riscv_double_in_struct
branch
from
9823576 to
ea1d15f
Compare
|
/azp run runtime-coreclr superpmi-diffs, runtime-coreclr superpmi-replay |
|
Azure Pipelines successfully started running 2 pipeline(s). |
jakobbotsch
approved these changes
Apr 12, 2023
|
The failure is stale, the job was renamed in #80718 |
7 tasks
shushanhf
reviewed
Apr 21, 2023
| @@ -961,19 +961,23 @@ void CodeGen::psiBegProlog() | |||
| else | |||
| { | |||
| regType = compiler->mangleVarArgsType(lclVarDsc->TypeGet()); | |||
| #ifdef TARGET_LOONGARCH | |||
There was a problem hiding this comment.
@t-mustafin
Please don't destroy the LoongArch64's code.
I revert it by #85151
There was a problem hiding this comment.
@shushanhf My mistake, sorry for that.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @jakobbotsch @gbalykov @clamp03 @alpencolt