Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LoongArch64] fix the errors for mod/div after #82924. #85140

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

shushanhf
Copy link
Contributor

This PR is part of the issue #69705 to amend the LA's port.

This should be merged after the #85085 to avoid conflict.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 21, 2023
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Apr 21, 2023
@ghost
Copy link

ghost commented Apr 21, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR is part of the issue #69705 to amend the LA's port.

This should be merged after the #85085 to avoid conflict.

Author: shushanhf
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@shushanhf
Copy link
Contributor Author

Hi, @jakobbotsch
I have tested this PR, could you please review this PR?
Thanks

@shushanhf
Copy link
Contributor Author

shushanhf commented Apr 24, 2023

Hi, @jakobbotsch I have tested this PR, could you please review this PR? Thanks

@BruceForstall @jakobbotsch

could you please review this PR?

As #82294 , the RISCV64 is based on LoongArch64, the RISCV64 is so similarity with LoongArch64.

What do you mean?
Is it that I have to fix the errors also for RISCV64 before you review this PR?
If needed, I can do it but I can just tested it on the LA64's PC as I don't have the RISCV64's env.

@jakobbotsch jakobbotsch merged commit c1f00a7 into dotnet:main Apr 24, 2023
@jakobbotsch
Copy link
Member

As #82294 , the RISCV64 is based on LoongArch64, the RISCV64 is so similarity with LoongArch64.

What do you mean? Is it that I have to fix the errors also for RISCV64 before you review this PR? If needed, I can do it but I can just tested it on the LA64's PC as I don't have the RISCV64's env.

If you have the extra cycles to fix RISC-V too then you should definitely feel free to include it in your change. You can also tag the RISC-V folks on your changes to make them aware that RISC-V may need similar fixes in the cases where RISC-V was based on LA64.

@shushanhf shushanhf deleted the fix_div-mod branch April 24, 2023 08:27
@shushanhf
Copy link
Contributor Author

As #82294 , the RISCV64 is based on LoongArch64, the RISCV64 is so similarity with LoongArch64.
What do you mean? Is it that I have to fix the errors also for RISCV64 before you review this PR? If needed, I can do it but I can just tested it on the LA64's PC as I don't have the RISCV64's env.

If you have the extra cycles to fix RISC-V too then you should definitely feel free to include it in your change. You can also tag the RISC-V folks on your changes to make them aware that RISC-V may need similar fixes in the cases where RISC-V was based on LA64.

At least most releated RISCV64 PRs is OK, but I can't test the RISCV64 while the LA64 had been tested.

@shushanhf
Copy link
Contributor Author

As #82294 , the RISCV64 is based on LoongArch64, the RISCV64 is so similarity with LoongArch64.
What do you mean? Is it that I have to fix the errors also for RISCV64 before you review this PR? If needed, I can do it but I can just tested it on the LA64's PC as I don't have the RISCV64's env.

If you have the extra cycles to fix RISC-V too then you should definitely feel free to include it in your change. You can also tag the RISC-V folks on your changes to make them aware that RISC-V may need similar fixes in the cases where RISC-V was based on LA64.

At least most releated RISCV64 PRs is OK, but I can test the RISCV64 while the LA64 had been tested.

@ghost ghost locked as resolved and limited conversation to collaborators May 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants