-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LoongArch64] fix the errors for mod/div after #82924. #85140
Conversation
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Hi, @jakobbotsch |
could you please review this PR? As #82294 , the RISCV64 is based on LoongArch64, the RISCV64 is so similarity with LoongArch64. What do you mean? |
If you have the extra cycles to fix RISC-V too then you should definitely feel free to include it in your change. You can also tag the RISC-V folks on your changes to make them aware that RISC-V may need similar fixes in the cases where RISC-V was based on LA64. |
At least most releated RISCV64 PRs is OK, but I can't test the RISCV64 while the LA64 had been tested. |
At least most releated RISCV64 PRs is OK, but I can test the RISCV64 while the LA64 had been tested. |
This PR is part of the issue #69705 to amend the LA's port.
This should be merged after the #85085 to avoid conflict.