-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Isolating JITDbl2Ulng helper changes #86175
Closed
khushal1996
wants to merge
13
commits into
dotnet:main
from
khushal1996:kcm-avx512-scalar-convert-draft-pr
Closed
Isolating JITDbl2Ulng helper changes #86175
khushal1996
wants to merge
13
commits into
dotnet:main
from
khushal1996:kcm-avx512-scalar-convert-draft-pr
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vtsd2usi uses ulong.max_value to show FPE for negative, NAN and ulong_max + 1 values.
…architecture. This is because we have changed the JITDbl2Ulng helper function to mimic the new IEEE compliant AVX512 instruction vcvtsd2usi. In the process, we needed to update the library test case because the default Floating Point Error (FPE) value for the new instruction is different from the default MSVC FPE value i.e. 0.
…not changing the library test case but the API to make sure NaN cases are handled.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
May 12, 2023
ghost
added
the
community-contribution
Indicates that the PR has been added by a community member
label
May 12, 2023
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsDraft PR for testing purposes. No need for review at this time.
|
…id handling edge cases (-1,0) separately inside the helper.
…ad dword and not qword for float to ulong
This was referenced May 18, 2023
… a special handling for vcvttss2usi64 to make sure we read only dword instead of qword for float to ulong conversion
ghost
locked as resolved and limited conversation to collaborators
Jun 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
community-contribution
Indicates that the PR has been added by a community member
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR for testing purposes. No need for review at this time.
Isolating the helper function changes to make sure that the helper function is working fine. This is w.r.t. the draft PR #84384
This PR optimize the following cases:
Assembly before optimization
Assembly afteroptimization
Assembly before optimization
Assembly afteroptimization
Assembly before optimization
Assembly afteroptimization