Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code coverage of corelib by updating coverlet #86566

Merged
merged 1 commit into from
May 22, 2023
Merged

Fix code coverage of corelib by updating coverlet #86566

merged 1 commit into from
May 22, 2023

Conversation

stephentoub
Copy link
Member

Fixes #81835

@ghost ghost assigned stephentoub May 22, 2023
@ghost
Copy link

ghost commented May 22, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #81835

Author: stephentoub
Assignees: -
Labels:

area-Infrastructure-libraries
Milestone: -

This was referenced May 22, 2023
Open
Closed
@build-analysis build-analysis bot mentioned this pull request May 22, 2023
Closed
ViktorHofer
ViktorHofer approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. It would be good to add CI protection at some point and verify that CoreLib is included in the coverage report.

@stephentoub stephentoub merged commit 1f15489 into dotnet:main May 22, 2023
@stephentoub stephentoub deleted the updatecoverlet branch May 22, 2023 10:19
@ghost ghost locked as resolved and limited conversation to collaborators Jun 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MarcoRossignoli MarcoRossignoli MarcoRossignoli approved these changes

@ViktorHofer ViktorHofer ViktorHofer approved these changes

Assignees

@stephentoub stephentoub

Labels
area-Infrastructure-libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code coverage failing for corelib
3 participants
@stephentoub @ViktorHofer @MarcoRossignoli