Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Microsoft.Extensions.Diagnostics.* to Aspnet Transport package #86725

Merged
merged 1 commit into from
May 25, 2023

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented May 24, 2023

Should unblock dotnet/aspnetcore#48407

@ghost
Copy link

ghost commented May 24, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Should unblock dotnet/aspnetcore#48407

Author: wtgodbe
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@ericstj ericstj requested a review from tarekgh May 24, 2023 21:00
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is really all it takes +💯

Copy link
Member

@ericstj ericstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tarekgh tarekgh added this to the 8.0.0 milestone May 24, 2023
@wtgodbe
Copy link
Member Author

wtgodbe commented May 24, 2023

/backport to release/8.0-preview5

@github-actions
Copy link
Contributor

Started backporting to release/8.0-preview5: https://github.com/dotnet/runtime/actions/runs/5073785356

@carlossanlop
Copy link
Member

CI failures were sudden platform crashes during test execution, unrelated. Merging now.

[16:18:04.7833420] Xamarin.Hosting: Process '46177' exited with exit code 1 or crashing signal .
[16:18:04.7838740] Application 'net.dot.System.Runtime.Tests' terminated (with exit code '1' and/or crashing signal ').

@carlossanlop carlossanlop merged commit 2eb128d into main May 25, 2023
@carlossanlop carlossanlop deleted the wtgodbe/diag branch May 25, 2023 02:17
@ghost ghost locked as resolved and limited conversation to collaborators Jun 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants