Add missing SHA3 helpers in HashAlgorithmNames #87237
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In PR dotnet#84132, the addition of SHA3 variants to the HashAlgorithmNames was incomplete, leaving out the explicit handling of the SHA3 variants from the two helper methods: - `ToUpper()` - Would just return the name **unchanged** (which is likely wrong as it would allow _sha3-256_ through instead of uppercasing to _SHA3-256_. That's probably wrong. - `ToAlgorithmName()` - Would return the `ToString()` on the supplied `hashAlgorithm` instance, which would be the classname of the argument `hashAlgorithm` (e.g. `"System.Security.Cryptography.SHA3_256"`). That would not match the expectation of `"SHA3-256"` based on the other instances. I am not sure how important these are, or if they should be wrapped in a `#if NET8_0_OR_GREATER` wrapper (only some of the new SHA3 stuff was wrapped in that PR)
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones Issue Detailsnull
|
IDisposable
changed the title
|
Looking for comments from @vcsjones and @steveharter |
|
Also I checked in unit tests for the |
vcsjones
reviewed
Jun 8, 2023
...ibraries/System.Security.Cryptography/src/System/Security/Cryptography/HashAlgorithmNames.cs
Show resolved
Hide resolved
This was referenced Jun 8, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #84132, the addition of SHA3 variants to the HashAlgorithmNames was incomplete, leaving out the explicit handling of the SHA3 variants from the two helper methods:
ToUpper()- Would just return the name unchanged (which is likely wrong as it would allow sha3-256 through instead of uppercasing to SHA3-256. That's probably wrong.ToAlgorithmName()- Would return theToString()on the suppliedhashAlgorithminstance, which would be the classname of the argumenthashAlgorithm(e.g."System.Security.Cryptography.SHA3_256"). That would not match the expectation of"SHA3-256"based on the other instances.I am not sure how important these are, or if they should be wrapped in a
#if NET8_0_OR_GREATERwrapper like only some of the new SHA3 stuff was wrapped in that PR.