Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delay load hook for singlefilehost and enable delay load of version.dll #87495

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

elinor-fung
Copy link
Member

coreclr delay loads version.dll and adds a hook such that it loads from the system directory. In single-file, we lost this behaviour since it uses static library version of coreclr. This adds the same mechanism to single-file.

…on.dll

`coreclr` delay loads `version.dll` and adds a hook such that it loads from the system directory. In single-file, we lost this behaviour since it uses static library version of `coreclr`. This adds the same mechanism to single-file.
@ghost
Copy link

ghost commented Jun 13, 2023

Tagging subscribers to this area: @agocke, @vitek-karas, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

coreclr delay loads version.dll and adds a hook such that it loads from the system directory. In single-file, we lost this behaviour since it uses static library version of coreclr. This adds the same mechanism to single-file.

Author: elinor-fung
Assignees: -
Labels:

area-Single-File

Milestone: -

@vitek-karas
Copy link
Member

All failures are unrelated.

@vitek-karas vitek-karas merged commit 8d3d7ea into dotnet:main Jun 14, 2023
@elinor-fung elinor-fung deleted the singlefile-delayLoadHook branch July 3, 2023 22:58
@ghost ghost locked as resolved and limited conversation to collaborators Aug 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants