-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to specify substitutions externally #88230
Conversation
ILLinker allows specifying substitutions on the command line, same as descriptors. This can be useful for various workarounds. Add support for this for ILC as well.
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsILLinker allows specifying substitutions on the command line, same as descriptors. This can be useful for various workarounds. Add support for this for ILC as well. Cc @dotnet/ilc-contrib
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good.
There are some illink tests which are currently disabled for NativeAOT because of this. I think it should be possible to reenable them (with some more infra work):
https://github.com/dotnet/runtime/blob/main/src/tools/illink/test/Mono.Linker.Tests.Cases/Warnings/CanWarnAsError.cs
Feel free to create an issue for that and link it to #82447. Doesn't have to be done now or as part of this PR.
Thanks! Opened #88647 and linked from the uber issue. |
ILLinker allows specifying substitutions on the command line, same as descriptors. This can be useful for various workarounds. Add support for this for ILC as well.
Cc @dotnet/ilc-contrib