Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update script to replace the BDN version being used in the PerfBDN app #89057

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

LoopedBard3
Copy link
Member

@LoopedBard3 LoopedBard3 commented Jul 17, 2023

PerfBDNApp builds are failing due to the BDN version passed to Benchmarks.Extensions and the Maui BDN version being different. Update script to replace the BDN version being used in the PerfBDN app to the same version we use in BDN extensions.

Internal test run for perfBDNApp: https://dev.azure.com/dnceng/internal/_build/results?buildId=2223932&view=results

…p to the same version we use for all BDN tests and in BDN extensions.
@ghost
Copy link

ghost commented Jul 17, 2023

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Update script to replace the BDN version being used in the PerfBDN app to the same version we use for all BDN tests and in BDN extensions.

Author: LoopedBard3
Assignees: LoopedBard3
Labels:

area-Infrastructure

Milestone: -

@LoopedBard3 LoopedBard3 merged commit 7358e1b into dotnet:main Jul 18, 2023
@LoopedBard3 LoopedBard3 deleted the PerfUpdateMobileBDNFlow branch July 18, 2023 16:51
LoopedBard3 added a commit that referenced this pull request Jul 20, 2023
Move performance repo clone to before the csproj update and pull out the BDNVersion value from the performance Versions.props.
@ghost ghost locked as resolved and limited conversation to collaborators Aug 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants