Remove Crossgen2's -O option in Test Builds Wherever Possible #89223

ivdiazsa · 2023-07-19T23:34:23Z

This PR fixes issue #56148. The -O option for Crossgen2 was required in the past for several reasons. However, nowadays it's causing issues in some tests that depend on their assembly's debug bit, which the -O option causes to be ignored.

all of them should be removed though.

ivdiazsa · 2023-07-25T18:26:03Z

@trylek Hi Tomas! I removed all the -O calls to Crossgen I could find, but I'm not sure if I missed others or whether some of these must remain. PTAL and let me know your thoughts.

ivdiazsa · 2023-07-25T18:58:26Z

/azp run runtime-coreclr outerloop

azure-pipelines · 2023-07-25T18:58:42Z

Azure Pipelines successfully started running 1 pipeline(s).

ivdiazsa · 2023-07-25T19:08:29Z

/azp help

azure-pipelines · 2023-07-25T19:08:34Z

Supported commands help: Get descriptions, examples and documentation about supported commands Example: help "command_name" list: List all pipelines for this repository using a comment. Example: "list" run: Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run. Example: "run" or "run pipeline_name, pipeline_name, pipeline_name" where: Report back the Azure DevOps orgs that are related to this repository and org Example: "where" See additional documentation.

ivdiazsa · 2023-07-25T19:11:13Z

/azp list

azure-pipelines · 2023-07-25T19:11:18Z

CI/CD Pipelines for this repository: runtime-coreclr outerloop runtime-coreclr jitstress runtime-coreclr jitstressregs runtime-coreclr jitstress2-jitstressregs runtime-coreclr gcstress0x3-gcstress0xc runtime-coreclr gcstress-extra runtime-coreclr r2r-extra runtime-coreclr jitstress-isas-x86 runtime-coreclr jitstress-isas-arm runtime-coreclr jitstressregs-x86 runtime-coreclr libraries-jitstressregs runtime-coreclr libraries-jitstress2-jitstressregs runtime-coreclr r2r runtime-coreclr runincontext runtime-coreclr crossgen2 runtime-libraries-coreclr outerloop runtime-libraries-coreclr outerloop-windows runtime-libraries-coreclr outerloop-linux runtime-libraries-coreclr outerloop-osx runtime runtime-libraries enterprise-linux runtime-libraries stress-http runtime-libraries stress-ssl runtime-dev-innerloop runtime-coreclr crossgen2 outerloop coreclr-release-outerloop-nightly runtime-coreclr crossgen2-composite runtime-jit-experimental runtime-coreclr libraries-jitstress dotnet-linker-tests runtime-coreclr ilasm runtime-coreclr crossgen2-composite gcstress runtime-staging runtime-coreclr pgo runtime-coreclr libraries-pgo Antigen runtime-community Fuzzlyn runtime-coreclr superpmi-replay runtime-wasm runtime-coreclr superpmi-diffs runtime-coreclr superpmi-asmdiffs-checked-release runtime-extra-platforms jit-cfg runtime-wasm-perf runtime-llvm runtime-coreclr jitstress-random runtime-coreclr libraries-jitstress-random runtime-android-grpc-client-tests runtime-wasm-libtests runtime-wasm-non-libtests runtime-android runtime-androidemulator runtime-ioslike runtime-ioslikesimulator runtime-linuxbionic runtime-maccatalyst runtime-coreclr pgostress runtime-coreclr jitstress-isas-avx512 runtime-tools-tests runtime-libraries-mono outerloop runtime-sanitized runtime-wasm-dbgtests runtime-wasm-optional

ivdiazsa · 2023-07-25T19:16:04Z

/azp run runtime-extra-platforms

azure-pipelines · 2023-07-25T19:16:25Z

Azure Pipelines successfully started running 1 pipeline(s).

trylek

Looks great to me, thank you!

ivdiazsa · 2023-07-26T18:07:31Z

Hmm seems like something broke in certain AOT configurations. Taking a look right now.

apparently are not happy without it.

ivdiazsa · 2023-07-26T23:06:47Z

/azp run runtime-extra-platforms

azure-pipelines · 2023-07-26T23:06:52Z

No commit pushedDate could be found for PR 89223 in repo dotnet/runtime

ivdiazsa · 2023-07-26T23:12:10Z

/azp run runtime-extra-platforms

azure-pipelines · 2023-07-26T23:12:22Z

Azure Pipelines successfully started running 1 pipeline(s).

…complaining.

ivdiazsa · 2023-07-27T18:18:32Z

/azp run runtime-extra-platforms

azure-pipelines · 2023-07-27T18:18:47Z

Azure Pipelines successfully started running 1 pipeline(s).

annoying pain.

ivdiazsa · 2023-07-28T21:34:30Z

/azp run runtime-extra-platforms

azure-pipelines · 2023-07-28T21:34:51Z

Azure Pipelines successfully started running 1 pipeline(s).

actually a problem with the extra-platforms, or they're just trolling at this point.

ivdiazsa · 2023-07-31T19:29:05Z

/azp run runtime-extra-platforms

azure-pipelines · 2023-07-31T19:29:20Z

Azure Pipelines successfully started running 1 pipeline(s).

ivdiazsa · 2023-07-31T20:42:10Z

/azp run runtime-extra-platforms

azure-pipelines · 2023-07-31T20:42:26Z

Azure Pipelines successfully started running 1 pipeline(s).

ivdiazsa · 2023-07-31T21:33:28Z

Extra Platforms seems to be utterly broken for Mono, completely unrelated to my changes. Will try to run only the default innerloop and outerloop with all the changes and if those pass, then this PR is ready to merge.

extra-platforms pipelines are super broken right now.

ivdiazsa · 2023-07-31T21:40:58Z

/azp run runtime-coreclr outerloop

azure-pipelines · 2023-07-31T21:41:09Z

Azure Pipelines successfully started running 1 pipeline(s).

ivdiazsa · 2023-08-01T21:14:41Z

R2R-CG2 failures are unrelated so merging this now.

Removed the Crossgen2 -O option from CLRTest.CrossGen.targets file.

8ad3d89

dotnet-issue-labeler bot added the area-crossgen2-coreclr label Jul 19, 2023

ivdiazsa self-assigned this Jul 19, 2023

ivdiazsa added this to the 8.0.0 milestone Jul 19, 2023

ivdiazsa linked an issue Jul 19, 2023 that may be closed by this pull request

R2R jobs should not pass -O to crossgen2 #56148

Closed

build-analysis bot mentioned this pull request Jul 20, 2023

Tracking issue for CI build timeouts #76454

Closed

Removed the remaining Crossgen2-related -O's I could find. Not sure if

7abb8ab

all of them should be removed though.

ivdiazsa marked this pull request as ready for review July 25, 2023 18:24

ivdiazsa requested a review from trylek July 25, 2023 18:24

dotnet deleted a comment from azure-pipelines bot Jul 25, 2023

trylek approved these changes Jul 25, 2023

View reviewed changes

Restored the ReadyToRunCompiler -O option because some NativeAOT tests

abb6af0

apparently are not happy without it.

This was referenced Jul 27, 2023

Roslyn source generator crash on mono/linux/arm64 #81123

Closed

Insufficient memory of docker containers on CI dotnet/dnceng#450

Open

[Android] Build failure: no previous prototype for function 'register_aot_modules' #89566

Closed

Restored crossgen-corelib.proj's -O because extra-platforms is still …

f38b764

…complaining.

This was referenced Jul 27, 2023

[6.0] Android test failure: Failed to install mobile app #83422

Open

[Android][Test] Failed to install mobile app #89567

Closed

Restored the -O in a python script to see if Mono stops being an

e006df2

annoying pain.

build-analysis bot mentioned this pull request Jul 29, 2023

[mono][ios] System.Formats.Tar.Tests are failing with System.ArgumentException #88049

Closed

Restored even the original change just to see whether there is

e51bc9e

actually a problem with the extra-platforms, or they're just trolling at this point.

Merge branch 'main' into obsolete-optimization

298fd4d

Removed the -O's from Crossgen2 again after discovering the

abd20ef

extra-platforms pipelines are super broken right now.

ivdiazsa merged commit ac464d2 into dotnet:main Aug 1, 2023

jakobbotsch mentioned this pull request Aug 9, 2023

Remove spurious assertion check causing .NET Core crashes #89986

Merged

AaronRobinsonMSFT mentioned this pull request Aug 9, 2023

Vector256 assert is firing for crossgen'd SPCL #90265

Closed

ivdiazsa mentioned this pull request Aug 9, 2023

Restore Crossgen2's Optimizations in CoreCLR Builds #90278

Merged

ghost locked as resolved and limited conversation to collaborators Sep 1, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove Crossgen2's -O option in Test Builds Wherever Possible #89223

Remove Crossgen2's -O option in Test Builds Wherever Possible #89223

ivdiazsa commented Jul 19, 2023

ivdiazsa commented Jul 25, 2023

ivdiazsa commented Jul 25, 2023

azure-pipelines bot commented Jul 25, 2023

ivdiazsa commented Jul 25, 2023

azure-pipelines bot commented Jul 25, 2023

ivdiazsa commented Jul 25, 2023

azure-pipelines bot commented Jul 25, 2023

ivdiazsa commented Jul 25, 2023

azure-pipelines bot commented Jul 25, 2023

trylek left a comment

ivdiazsa commented Jul 26, 2023

ivdiazsa commented Jul 26, 2023

azure-pipelines bot commented Jul 26, 2023

ivdiazsa commented Jul 26, 2023

azure-pipelines bot commented Jul 26, 2023

ivdiazsa commented Jul 27, 2023

azure-pipelines bot commented Jul 27, 2023

ivdiazsa commented Jul 28, 2023

azure-pipelines bot commented Jul 28, 2023

ivdiazsa commented Jul 31, 2023

azure-pipelines bot commented Jul 31, 2023

ivdiazsa commented Jul 31, 2023

azure-pipelines bot commented Jul 31, 2023

ivdiazsa commented Jul 31, 2023

ivdiazsa commented Jul 31, 2023

azure-pipelines bot commented Jul 31, 2023

ivdiazsa commented Aug 1, 2023

Remove Crossgen2's -O option in Test Builds Wherever Possible #89223

Remove Crossgen2's -O option in Test Builds Wherever Possible #89223

Conversation

ivdiazsa commented Jul 19, 2023

ivdiazsa commented Jul 25, 2023

ivdiazsa commented Jul 25, 2023

azure-pipelines bot commented Jul 25, 2023

ivdiazsa commented Jul 25, 2023

azure-pipelines bot commented Jul 25, 2023

ivdiazsa commented Jul 25, 2023

azure-pipelines bot commented Jul 25, 2023

ivdiazsa commented Jul 25, 2023

azure-pipelines bot commented Jul 25, 2023

trylek left a comment

Choose a reason for hiding this comment

ivdiazsa commented Jul 26, 2023

ivdiazsa commented Jul 26, 2023

azure-pipelines bot commented Jul 26, 2023

ivdiazsa commented Jul 26, 2023

azure-pipelines bot commented Jul 26, 2023

ivdiazsa commented Jul 27, 2023

azure-pipelines bot commented Jul 27, 2023

ivdiazsa commented Jul 28, 2023

azure-pipelines bot commented Jul 28, 2023

ivdiazsa commented Jul 31, 2023

azure-pipelines bot commented Jul 31, 2023

ivdiazsa commented Jul 31, 2023

azure-pipelines bot commented Jul 31, 2023

ivdiazsa commented Jul 31, 2023

ivdiazsa commented Jul 31, 2023

azure-pipelines bot commented Jul 31, 2023

ivdiazsa commented Aug 1, 2023