Fix a bunch of DWARF errors #89488
Merged
Fix a bunch of DWARF errors #89488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I ran `dwarfdump --verify` on the object file we produce and noticed that a bunch of these overlapping ranges looks suspicious. Sure enough there is a trap that we fell into.
```
error: DIEs have overlapping address ranges:
0x0005a8e6: DW_TAG_catch_block [38] (0x0005a85b)
DW_AT_low_pc [DW_FORM_addr] (0x0000000000065981 "__managedcode")
DW_AT_high_pc [DW_FORM_data8] (0x0000000000000102)
0x0005a8d5: DW_TAG_try_block [37] (0x0005a85b)
DW_AT_low_pc [DW_FORM_addr] (0x00000000000658bb "__managedcode")
DW_AT_high_pc [DW_FORM_data8] (0x00000000000000d2)
error: DIE address ranges are not contained in its parent's ranges:
0x0005a85b: DW_TAG_subprogram [10] * (0x0000000b)
DW_AT_specification [DW_FORM_ref4] (cu + 0x2faae => {0x0002faae} "S_P_TypeLoader_System_Collections_Generic_LowLevelDictionary_2<System___Canon__System___Canon>__ExpandBuckets")
DW_AT_low_pc [DW_FORM_addr] (0x00000000000658a0 "__managedcode")
DW_AT_high_pc [DW_FORM_data8] (0x0000000000000102)
DW_AT_frame_base [DW_FORM_exprloc] (DW_OP_reg6)
DW_AT_object_pointer [DW_FORM_ref4] (cu + 0x5a876 => {0x0005a876})
0x0005a8e6: DW_TAG_catch_block [38] (0x0005a85b)
DW_AT_low_pc [DW_FORM_addr] (0x0000000000065981 "__managedcode")
DW_AT_high_pc [DW_FORM_data8] (0x0000000000000102)
```
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsI ran The only remaining errors that I see look like this: We probably need to do something around Then we'll need to fix up our testing to look at object files because the final executable has a bunch of dwarf errors on things generated by clang - we should look at the object file instead. Cc @dotnet/ilc-contrib
|
ghost
assigned 
jkotas
approved these changes
Jul 26, 2023
filipnavara
approved these changes
Jul 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran
dwarfdump --verifyon the object file we produce and noticed that a bunch of these overlapping ranges looks suspicious. Sure enough there is a trap that we fell into.The only remaining errors that I see look like this:
We probably need to do something around
CORINFO_EH_CLAUSE_SAMETRY.Then we'll need to fix up our testing to look at object files because the final executable has a bunch of dwarf errors on things generated by clang - we should look at the object file instead.
Cc @dotnet/ilc-contrib