Fix whole program optimization option for Windows #91759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent change to cleanup the way some options in Windows builds of the runtime are overriden missed the fact that the CMAKE_INTERPROCEDURAL_OPTIMIZATION cannot contain generator expressions and so it was always set to "off". The fix is to set CMAKE_INTERPROCEDURAL_OPTIMIZATION_RELEASE and CMAKE_INTERPROCEDURAL_OPTIMIZATION_RELWITHDEBUGINFO instead. I have also missed two places before where we were still adding /GL-.
|
Tagging subscribers to this area: @hoyosjs Issue DetailsThe recent change to clean up the way some options in Windows builds of the runtime are overridden missed the fact that the The fix is to set
|
|
cc: @elinor-fung |
hoyosjs
approved these changes
Sep 7, 2023
jkoritzinsky
approved these changes
Sep 7, 2023
|
👍 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent change to clean up the way some options in Windows builds of the runtime are overridden missed the fact that the
CMAKE_INTERPROCEDURAL_OPTIMIZATIONcannot contain generator expressions and so it was always set to "off".The fix is to set
CMAKE_INTERPROCEDURAL_OPTIMIZATION_RELEASEandCMAKE_INTERPROCEDURAL_OPTIMIZATION_RELWITHDEBUGINFOinstead.