Consuming the return type instead of an interface #95601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsDescriptionSince Perhaps it makes more sense even to use a RegressionNegative regression, i.e. perf improvement. TestingNo new tests are needed.
|
stephentoub
reviewed
Dec 4, 2023
src/libraries/System.Net.Mail/src/System/Net/Mail/MailAddressCollection.cs
Show resolved
Hide resolved
rzikm
approved these changes
Dec 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since
MailAddressParser.ParseMultipleAddressesreturns an instance ofList<MailAddress>it makes much more sense to comsume it as is rather than do virtual calls and hope that the JIT compiler would eliminate them.Perhaps it makes more sense even to use a
foreachloop, but I decided to go with a simple change and move forward if it's okay.Regression
Negative regression, i.e. perf improvement.
Testing
No new tests are needed.