Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect ResponseHeaderEncodingSelector for the Location header #95810

Merged
merged 1 commit into from
Dec 10, 2023

Conversation

MihaZupan
Copy link
Member

Fixes #95799

If the user sets the ResponseHeaderEncodingSelector and the callback gives us an encoding for the location header, use that before trying to guess whether the bytes are UTF-8 or not.

@MihaZupan MihaZupan added this to the 9.0.0 milestone Dec 8, 2023
@MihaZupan MihaZupan requested a review from a team December 8, 2023 23:32
@MihaZupan MihaZupan self-assigned this Dec 8, 2023
@ghost
Copy link

ghost commented Dec 8, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #95799

If the user sets the ResponseHeaderEncodingSelector and the callback gives us an encoding for the location header, use that before trying to guess whether the bytes are UTF-8 or not.

Author: MihaZupan
Assignees: MihaZupan
Labels:

area-System.Net.Http

Milestone: 9.0.0

Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MihaZupan MihaZupan merged commit 6de7549 into dotnet:main Dec 10, 2023
111 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SocketsHttpHandler.ResponseHeaderEncodingSelector may be ignored for Location headers
2 participants