Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifying indent size and whitespace character when writing JSON #95985

Closed
wants to merge 8 commits into from
Closed

Allow specifying indent size and whitespace character when writing JSON #95985

wants to merge 8 commits into from

Conversation

noqn
Copy link

@noqn noqn commented Dec 13, 2023

Closes #63882

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Dec 13, 2023
@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Dec 13, 2023

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

Closes #63882

Author: noqn
Assignees: -
Labels:

area-System.Text.Json, new-api-needs-documentation, community-contribution
Milestone: -

@noqn
Copy link
Author

noqn commented Dec 13, 2023

@dotnet-policy-service agree

@build-analysis build-analysis bot mentioned this pull request Dec 14, 2023
Closed
@eiriktsarpalis
Copy link
Member

Thanks, but given that we already have #95292 under review I would recommend we keep this in draft mode for now. We can revive it should the need arise.

@eiriktsarpalis eiriktsarpalis marked this pull request as draft December 14, 2023 06:49
@build-analysis build-analysis bot mentioned this pull request Dec 15, 2023
Closed
@noqn noqn marked this pull request as ready for review December 15, 2023 21:38
@adamsitnik
Copy link
Member

Thanks, but given that we already have #95292 under review

@eiriktsarpalis #95292 got merged, should this PR be closed then?

@eiriktsarpalis
Copy link
Member

Looks like. Thank you for fielding the prototype @noqn

@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
area-System.Text.Json community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[API Proposal]: Allow specifying indent size and whitespace character when writing JSON with Utf8JsonWriter
3 participants
@noqn @eiriktsarpalis @adamsitnik