Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Augment the backport PR description template to prompt for more info #97073

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Augment the backport PR description template to prompt for more info #97073

merged 2 commits into from
Jan 17, 2024

Conversation

jeffhandley
Copy link
Member

Taking inspiration from dotnet/aspnetcore's backport template, this augments ours to prompt for:

  1. Customer reported, or found internally
  2. Regression (if so, when was it introduced)
  3. How the issue escaped testing
  4. Justifying the declared risk

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jan 17, 2024
@ghost ghost assigned jeffhandley Jan 17, 2024
@jeffhandley jeffhandley added area-Meta and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jan 17, 2024
@ghost
Copy link

ghost commented Jan 17, 2024

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

Taking inspiration from dotnet/aspnetcore's backport template, this augments ours to prompt for:

  1. Customer reported, or found internally
  2. Regression (if so, when was it introduced)
  3. How the issue escaped testing
  4. Justifying the declared risk
Author: jeffhandley
Assignees: jeffhandley
Labels:

area-Meta
Milestone: -

danmoseley
danmoseley approved these changes Jan 17, 2024
View reviewed changes
.github/workflows/backport.yml Outdated Show resolved Hide resolved
artl93
artl93 approved these changes Jan 17, 2024
View reviewed changes
.github/workflows/backport.yml Outdated Show resolved Hide resolved
jeffschwMSFT
jeffschwMSFT approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jeffhandley jeffhandley merged commit 3b58f10 into dotnet:main Jan 17, 2024
5 checks passed
@jeffhandley jeffhandley deleted the jeffhandley/backport-template branch January 17, 2024 19:35
tmds pushed a commit to tmds/runtime that referenced this pull request Jan 23, 2024
@jeffhandley @tmds
Augment the backport PR description template to prompt for more info (d…
b6d1561 
…otnet#97073)

* Augment the backport PR description template to prompt for more info

* Wordsmith the backport template prompts per feedback
@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@artl93 artl93 artl93 approved these changes

@jeffschwMSFT jeffschwMSFT jeffschwMSFT approved these changes

@danmoseley danmoseley danmoseley approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar

Assignees

@jeffhandley jeffhandley

Labels
area-Meta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeffhandley @danmoseley @jeffschwMSFT @artl93