Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging dotnet/runtime master branch back into Utf8String experiment branch. #23

Merged
merged 106 commits into from
Jul 23, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
106 commits
Select commit Hold shift + click to select a range
df4c719
[mono] Fix an assert which happens when marshalling ftnptr types. (#3…
vargaz Jul 17, 2020
e0913bd
Enable FEATURE_METADATA_VERIFY_LAYOUTS (#39451)
sdmaclea Jul 17, 2020
cc6d54c
Guard SseImpl method body with IsSupported check (#39246)
AndyAyersMS Jul 17, 2020
49186d7
Fix liveness of FrameListRoot (#39452)
CarolEidt Jul 17, 2020
87d8f7d
Revert "Kill REG_PROFILER_RET_SCRATCH (#37679)" (#39335)
AndyAyersMS Jul 17, 2020
329f0db
Mark Obsoletions for .NET 5 (#39269)
jeffhandley Jul 18, 2020
264cb76
Disable slow tests under GCStress (#39545)
BruceForstall Jul 18, 2020
f6dc87f
Add Convert.ToHexString/FromHexString
tkp1n Jul 18, 2020
f4b1d3c
Correct test to account for PLINQ Zip unordered behavior (#39553)
Clockwork-Muse Jul 18, 2020
4060615
Add breaking change version DAC API (ISOSDacInterface9 interface) (#3…
mikem8361 Jul 18, 2020
328fc0f
Remove some non-unicode characters from source code (#39527)
monojenkins Jul 18, 2020
177d6f1
Implement IComparable on Rune (#39541)
GrabYourPitchforks Jul 18, 2020
1d12f2b
Remove unused local variables and methods from System.Drawing.Common …
MattKotsenas Jul 18, 2020
1f62294
Remove unused locals in System.IO.FileSystem.* (#39552)
MattKotsenas Jul 18, 2020
90d47a7
Add more information to test timeout message (#39558)
BruceForstall Jul 18, 2020
8e7b5ae
Disable Vector tests failing under GCStress (#39580)
BruceForstall Jul 18, 2020
595402c
Remove unused locals in System.IO.Ports (#39557)
MattKotsenas Jul 18, 2020
ad325b0
Fix GC poll insertion for `BBJ_CALLFINALLY` basic blocks. (#39564)
erozenfeld Jul 18, 2020
16830d1
Disable Interop\COM\Dynamic\Dynamic under GCStress (#39585)
BruceForstall Jul 18, 2020
fcfcc92
Remove unused locals in System.Configuration.ConfigurationManager (#3…
MattKotsenas Jul 18, 2020
b570558
Use static lambdas in several libraries (#39273)
stephentoub Jul 18, 2020
3f7202b
Replace USE_INTERNAL_ACCESSIBILITY with SYSTEM_PRIVATE_CORELIB (#39588)
jkotas Jul 18, 2020
a9b0beb
Correct TryReadTo ref assembly parameter name (#39594)
benaadams Jul 18, 2020
9026457
Remove SELECTANY usage (#39532)
janvorli Jul 18, 2020
0f4d1d8
Make Comments In SortedList Match Code Bahaviour (#39595)
taoyouh Jul 18, 2020
1d08d98
Remove unused locals in System.Management (#39570)
MattKotsenas Jul 18, 2020
bb27de1
Fix il verification tests (#39538)
davidwrighton Jul 18, 2020
6af0d0e
Fix resx test name mangling logic (#39569)
GrabYourPitchforks Jul 18, 2020
62f2588
Annotate and adjust more of CoreLib for trimming (#38865)
MichalStrehovsky Jul 18, 2020
b613cbe
[wasm] Trim down size of dotnet.wasm (#39549)
BrzVlad Jul 18, 2020
f4e9146
Test EmbeddedSignatureData api (#39329)
davidwrighton Jul 18, 2020
9a5ef96
add SupportsTls11 and SupportsTls12 to PlatformDetection avoid OS ver…
wfurt Jul 20, 2020
0e23ef4
Reenable gcdump test (#39555)
davmason Jul 20, 2020
0e0e648
Synchronize dataflow annotations accross virtual methods (#39458)
MichalStrehovsky Jul 20, 2020
06700b4
Sync shared compiler file (#39164)
MichalStrehovsky Jul 20, 2020
628d99b
Properly map exceptions from NetworkStream ctor. (#39514)
ManickaP Jul 20, 2020
867ad8d
[wasm][debugger] Don't download unnecessary assemblies to DebugProxy …
thaystg Jul 20, 2020
945beee
[wasm] Include data archives and timezone data by default (#39586)
lewing Jul 20, 2020
a366d63
[wasm] Sort Assembly List in WASM Apps (#39374)
mdh1418 Jul 20, 2020
0655692
[mono] Update ICU version, disable some tests for Browser (#39596)
EgorBo Jul 20, 2020
d8d4d9e
Create and add instance reference inside ResolveMetadata* (#39330)
jozkee Jul 20, 2020
c652058
Add PNSE on non-Browser for S.R.I.JavaScript and clean up references …
akoeplinger Jul 20, 2020
d5b61d8
[wasm] Enable System.CodeDom.Tests test suite (#39626)
MaximLipnin Jul 20, 2020
6998f4c
Unify resource strings used for Browser PNSE (#39637)
akoeplinger Jul 20, 2020
e0d20d3
[wasm] Address System.Text.RegularExpressions.Tests Failures (#39470)
mdh1418 Jul 20, 2020
1ab372c
Fix fd leak in Diagnostics Server and add better error handling (#39129)
Jul 20, 2020
dc00345
Add ProcessInfo command to Diagnostics Server (#38967)
Jul 20, 2020
d252f29
Apply missing obsolete attributes in src; fix attribute ordering (#39…
jeffhandley Jul 20, 2020
0a1f7ba
Allow Debugger attributes to be trimmed in Mono (#39479)
eerhardt Jul 20, 2020
874399a
Declare AllowReversePInvokeCallsAttribute as Obsolete. (#39636)
AaronRobinsonMSFT Jul 20, 2020
36041c5
Fix tiering assertion failures from concurrent or reentering JIT of t…
kouvel Jul 20, 2020
25b6106
Revert "Fix resx test name mangling logic" (#39644)
GrabYourPitchforks Jul 20, 2020
7324741
AdvSimd support for System.Text.Unicode.Utf8Utility.TranscodeToUtf8 (…
carlossanlop Jul 20, 2020
9d88a94
AdvSimd support for System.Text.Unicode.Utf8Utility.GetPointerToFirst…
carlossanlop Jul 20, 2020
562763b
Fix build failure in net472 debug AdvSimd Utf16Utility (#39652)
carlossanlop Jul 20, 2020
c44ea8f
[master] Update dependencies from mono/linker Microsoft/vstest dotnet…
dotnet-maestro[bot] Jul 20, 2020
6bb6060
Add CoffeeFlux to area-VM-meta-mono (#39659)
CoffeeFlux Jul 21, 2020
c399806
Fix tailCall check for CallI. (#39621)
Jul 21, 2020
0c79b70
Fixing a memory ordering issue in AsymmetricLock and enabling MemoryB…
VSadov Jul 21, 2020
0df6dac
Start using UnmanagedCallersOnly in CoreLib (#39082)
jkotas Jul 21, 2020
82d7d5f
fix missing command case (#39686)
Jul 21, 2020
650f28f
Add JsonNumberHandling(Attribute) & support for (de)serializing numbe…
layomia Jul 21, 2020
911cf2c
Disable getappdomainstaticaddress for JIT stress modes (#39667)
BruceForstall Jul 21, 2020
f0a41ac
Do not touch crossgen if crossgen is not requested (#39628)
gbalykov Jul 21, 2020
c2d2397
WASM: Enable System.Reflection.MetadataLoadContext tests (#39651)
akoeplinger Jul 21, 2020
cde939d
Fix TableOutOfRangeException in Crossgen2 (#39653)
trylek Jul 21, 2020
bf0076c
[browser][tests] Activate System.Runtime.Extensions UserName tests (#…
kjpou1 Jul 21, 2020
d129af6
Add CryptoStream.FlushFinalBlockAsync
vcsjones Jul 21, 2020
632cdca
Trim more Http DiagnosticsHandler code (#39525)
eerhardt Jul 21, 2020
2b94d13
Update license header in NameResolutionTelemetry (#39711)
MihaZupan Jul 21, 2020
3b1b623
Fix hosted crossgen2 build on arm64 (#39537)
omajid Jul 21, 2020
c5b39f3
Enable builds of internal branches (#39437)
mmitche Jul 21, 2020
1a6016d
Disable crossgen2smoke test for GCStress (#39680)
BruceForstall Jul 21, 2020
b11aea3
Clean up code following JSON number handling and field support PRs (#…
layomia Jul 21, 2020
f501577
WASM: Enable System.Reflection tests (#39696)
akoeplinger Jul 21, 2020
932ea66
[wasm] Enable System.ComponentModel.TypeConverter test suite (#39710)
MaximLipnin Jul 21, 2020
7adab7c
Modify build-test scripts to use response files for Crossgen compilat…
trylek Jul 21, 2020
ed6eda5
[runtime] Initialize the class if needed in type_is_blittable (). (#3…
vargaz Jul 21, 2020
69ef55e
Fix libraries outerloop builds (#39735)
safern Jul 21, 2020
e87fbd1
Add Overloads for Add(Json/Systemd/Simple)Console (#39725)
maryamariyan Jul 21, 2020
9e846df
Add note about the tagging bot to area-owners.md (#39750)
akoeplinger Jul 22, 2020
d8cf13e
Use lib prefix for native library names for consistency (#39717)
jkotas Jul 22, 2020
fd1cff8
Move `GetLclOffs` method to `GenTreeLclVarCommon`. (#39623)
Jul 22, 2020
0cee949
CI Integration for Cross OS DAC (#39574)
hoyosjs Jul 22, 2020
8087ae5
[wasm] Enable System.Xml.XmlSerializer.ReflectionOnly.Tests, System.X…
MaximLipnin Jul 22, 2020
df9873f
[wasm] WasmAppBuilder write the json as json (#39660)
lewing Jul 22, 2020
1d0eb4b
Use function pointers in more places (#39752)
jkotas Jul 22, 2020
290bc3a
[wasm] Enable System.Linq.Expressions.Tests test suite (#39772)
MaximLipnin Jul 22, 2020
90a31ee
Fix some scenarios for DynamicRevocationTests on macOS.
vcsjones Jul 22, 2020
8ddc945
Allow higher iteration counts for PBES2
vcsjones Jul 22, 2020
ea82629
Add runtimelab.yml for dotnet/runtimelab experiments CI and build inf…
joperezr Jul 22, 2020
1616d2e
Add rules for changing InstructionSetDesc.txt (#39777)
jkotas Jul 22, 2020
49fe946
Fix double-writes in test projects (#39778)
ViktorHofer Jul 22, 2020
ffe0ab1
MEH test failure on mono (#39784)
maryamariyan Jul 22, 2020
847f2fa
Add missing space padding before exception message in log (#39534) (#…
maryamariyan Jul 22, 2020
c4ef4bc
[Infra] collect dumps of all corerun in tree on timeout (#38647)
Jul 22, 2020
acbefed
Remove BundleDir/PublishDir at the end of ArchiveTests to save disk s…
akoeplinger Jul 22, 2020
d77ef3e
[wasm] add zone.tab to dotnet.timezones.blat (#39731)
tqiu8 Jul 22, 2020
15e9df5
Add events around type load and r2r usage (#39656)
davidwrighton Jul 22, 2020
9cc14a8
fix CborWriter bug when writing tagged empty collections (#39786)
eiriktsarpalis Jul 22, 2020
19e4e45
Update the JITEEVersionIdentifier (#39779)
tannergooding Jul 22, 2020
9a8737d
[runtime] Make sure newly created objects are pinned during a runtime…
vargaz Jul 22, 2020
66a7205
Limit arm32 Windows testing. (#39655)
erozenfeld Jul 22, 2020
fc7381c
Fix Failing Casing Tests with Invariant Culture (#39747)
tarekgh Jul 22, 2020
9c3f017
[browser][file system] GetLogicalDrives implementation (#39763)
kjpou1 Jul 22, 2020
073fe07
Merge dotnet/runtime "master" branch into Utf8String
joperezr Jul 22, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
4 changes: 4 additions & 0 deletions .editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,10 @@ indent_size = 2
[*.{props,targets,config,nuspec}]
indent_size = 2

# YAML config files
[*.{yml,yaml}]
indent_size = 2

# Shell scripts
[*.sh]
end_of_line = lf
Expand Down
6 changes: 4 additions & 2 deletions docs/area-owners.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
If you need to tag folks on an issue or PR, you will generally want to tag the owners (not the lead)
If you need to tag folks on an issue or PR, you will generally want to tag the owners (not the lead).

Note: Editing this file doesn't update the mapping used by the `@msftbot` issue notification bot to tag owners. Some area owners prefer not to get those notifications. To update those notifications, contact any one of `@danmosemsft`, `@jeffschw`, `@ericstj`, or `@karelz`. If you're a community member interested in these notifications, you won't appear in this table but we can add you to notifications - just let us know.

| Area | Lead | Owners (area experts to tag in PR's and issues) | Description |
|------------------------------------------------|---------------|-----------------------------------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
Expand Down Expand Up @@ -118,4 +120,4 @@ If you need to tag folks on an issue or PR, you will generally want to tag the o
| area-TypeSystem-coreclr | @mangod9 | @davidwrighton @MichalStrehovsky @janvorli @mangod9 | |
| area-UWP | @tommcdon | @jashook | UWP-specific issues including Microsoft.NETCore.UniversalWindowsPlatform and Microsoft.Net.UWPCoreRuntimeSdk |
| area-VM-coreclr | @mangod9 | @mangod9 | |
| area-VM-meta-mono | @SamMonoRT | @lambdageek | |
| area-VM-meta-mono | @SamMonoRT | @lambdageek @CoffeeFlux | |
24 changes: 16 additions & 8 deletions docs/project/list-of-obsoletions.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,24 @@ List of Obsoletions

Per https://github.com/dotnet/designs/blob/master/accepted/2020/better-obsoletion/better-obsoletion.md, we now have a strategy in place for marking existing APIs as `[Obsolete]`. This takes advantage of the new diagnostic id and URL template mechanisms introduced to `ObsoleteAttribute` in .NET 5.

When obsoleting an API, use the diagnostic ID `MSLIB####`, where _\#\#\#\#_ is the next four-digit identifier in the sequence, and add it to the list below. This helps us maintain a centralized location of all APIs that were obsoleted using this mechanism.
When obsoleting an API, use the diagnostic ID `SYSLIB####`, where _\#\#\#\#_ is the next four-digit identifier in the sequence, and add it to the list below. This helps us maintain a centralized location of all APIs that were obsoleted using this mechanism.

The URL template we use for obsoletions is `https://aka.ms/dotnet-warnings/{0}`.

Currently the identifiers `MSLIB0001` through `MSLIB0999` are carved out for obsoletions. If we wish to introduce analyzer warnings not related to obsoletion in the future, we should begin at a different range, such as `MSLIB2000`.
Currently the identifiers `SYSLIB0001` through `SYSLIB0999` are carved out for obsoletions. If we wish to introduce analyzer warnings not related to obsoletion in the future, we should begin at a different range, such as `SYSLIB2000`.

## Current obsoletions (`MSLIB0001` - `MSLIB0999`)
## Current obsoletions (`SYSLIB0001` - `SYSLIB0999`)

| Diagnostic ID | Description |
| :--------------- | :---------- |
| __`MSLIB0001`__ | The UTF-7 encoding is insecure and should not be used. Consider using UTF-8 instead. |
| __`MSLIB0002`__ | `PrincipalPermissionAttribute` is not honored by the runtime and must not be used. |
| __`MSLIB0003`__ | `BinaryFormatter` serialization is obsolete and should not be used. See https://aka.ms/binaryformatter for recommended alternatives. |
| Diagnostic ID | Description |
| :---------------- | :---------- |
| __`SYSLIB0001`__ | The UTF-7 encoding is insecure and should not be used. Consider using UTF-8 instead. |
| __`SYSLIB0002`__ | PrincipalPermissionAttribute is not honored by the runtime and must not be used. |
| __`SYSLIB0003`__ | Code Access Security is not supported or honored by the runtime. |
| __`SYSLIB0004`__ | The Constrained Execution Region (CER) feature is not supported. |
| __`SYSLIB0005`__ | The Global Assembly Cache is not supported. |
| __`SYSLIB0006`__ | Thread.Abort is not supported and throws PlatformNotSupportedException. |
| __`SYSLIB0007`__ | The default implementation of this cryptography algorithm is not supported. |
| __`SYSLIB0008`__ | The CreatePdbGenerator API is not supported and throws PlatformNotSupportedException. |
| __`SYSLIB0009`__ | The AuthenticationManager Authenticate and PreAuthenticate methods are not supported and throw PlatformNotSupportedException. |
| __`SYSLIB0010`__ | This Remoting API is not supported and throws PlatformNotSupportedException. |
| __`SYSLIB0011`__ | `BinaryFormatter` serialization is obsolete and should not be used. See https://aka.ms/binaryformatter for recommended alternatives. |
2 changes: 1 addition & 1 deletion docs/workflow/trimming/feature-switches.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ configurations but their defaults might vary as any SDK can set the defaults dif
| EventSourceSupport | System.Diagnostics.Tracing.EventSource.IsSupported | Any EventSource related code or logic is trimmed when set to false |
| InvariantGlobalization | System.Globalization.Invariant | All globalization specific code and data is trimmed when set to true |
| UseSystemResourceKeys | System.Resources.UseSystemResourceKeys | Any localizable resources for system assemblies is trimmed when set to true |
| - | System.Net.Http.EnableActivityPropagation | Any dependency related to diagnostics support for System.Net.Http is trimmed when set to false |
| HttpActivityPropagationSupport | System.Net.Http.EnableActivityPropagation | Any dependency related to diagnostics support for System.Net.Http is trimmed when set to false |

Any feature-switch which defines property can be set in csproj file or
on the command line as any other MSBuild property. Those without predefined property name
Expand Down
18 changes: 12 additions & 6 deletions eng/Subsets.props
Original file line number Diff line number Diff line change
Expand Up @@ -79,12 +79,14 @@
<!-- CoreClr -->
<SubsetName Include="Clr" Description="The CoreCLR runtime, LinuxDac, CoreLib (+ native), tools and packages." />
<SubsetName Include="Clr.Runtime" Description="The CoreCLR .NET runtime." />
<SubsetName Include="LinuxDac" Condition="$([MSBuild]::IsOsPlatform(Windows))" Description="The cross-OS Windows->libc-based Linux DAC. Skipped on x86." />
<SubsetName Include="AlpineDac" Condition="$([MSBuild]::IsOsPlatform(Windows))" OnDemand="true" Description="The cross-OS Windows->musl-libc-based Linux DAC. Skipped on x86." />
<SubsetName Include="Clr.CoreLib" Description="The managed System.Private.CoreLib library for CoreCLR." />
<SubsetName Include="Clr.NativeCoreLib" Description="Run crossgen on System.Private.CoreLib library for CoreCLR." />
<SubsetName Include="Clr.Tools" Description="Managed tools that support CoreCLR development and testing." />
<SubsetName Include="Clr.Packages" Description="The projects that produce NuGet packages for the CoreCLR runtime, crossgen, and IL tools." />
<SubsetName Include="LinuxDac" Condition="$([MSBuild]::IsOsPlatform(Windows))" Description="The cross-OS Windows->libc-based Linux DAC. Skipped on x86." />
<SubsetName Include="AlpineDac" Condition="$([MSBuild]::IsOsPlatform(Windows))" OnDemand="true" Description="The cross-OS Windows->musl-libc-based Linux DAC. Skipped on x86 and arm." />
<SubsetName Include="CrossDacPack" OnDemand="true"
Description="Packaging of cross OS DAC. Requires all assets needed to be present at a folder specified by $(CrossDacArtifactsDir). See 'Microsoft.CrossOsDiag.Private.CoreCLR.proj' for details." />

<!-- Mono -->
<SubsetName Include="Mono" Description="The Mono runtime and CoreLib." />
Expand Down Expand Up @@ -136,10 +138,14 @@
<ProjectToBuild Include="$(CoreClrProjectRoot)runtime.proj" AdditionalProperties="%(AdditionalProperties);CrossDac=linux" Category="clr" />
</ItemGroup>

<ItemGroup Condition="$(_subset.Contains('+alpinedac+')) and $([MSBuild]::IsOsPlatform(Windows)) and '$(TargetArchitecture)' != 'x86'">
<ItemGroup Condition="$(_subset.Contains('+alpinedac+')) and $([MSBuild]::IsOsPlatform(Windows)) and '$(TargetArchitecture)' != 'x86' and '$(TargetArchitecture)' != 'arm'">
<ProjectToBuild Include="$(CoreClrProjectRoot)runtime.proj" AdditionalProperties="%(AdditionalProperties);CrossDac=alpine" Category="clr" />
</ItemGroup>

<ItemGroup Condition="$(_subset.Contains('+crossdacpack+'))">
<ProjectToBuild Include="$(CoreClrProjectRoot)src\.nuget\Microsoft.CrossOsDiag.Private.CoreCLR\Microsoft.CrossOsDiag.Private.CoreCLR.proj" Category="clr" />
</ItemGroup>

<ItemGroup Condition="$(_subset.Contains('+clr.nativecorelib+'))">
<ProjectToBuild Include="$(CoreClrProjectRoot)crossgen-corelib.proj" Category="clr" />
</ItemGroup>
Expand Down Expand Up @@ -256,9 +262,9 @@
<!-- Set default configurations. -->
<ItemGroup>
<ProjectToBuild Update="@(ProjectToBuild)">
<AdditionalProperties Condition="'%(ProjectToBuild.Category)' == 'clr' and '$(CoreCLRConfiguration)' != ''">Configuration=$(CoreCLRConfiguration)</AdditionalProperties>
<AdditionalProperties Condition="'%(ProjectToBuild.Category)' == 'mono' and '$(MonoConfiguration)' != ''">Configuration=$(MonoConfiguration)</AdditionalProperties>
<AdditionalProperties Condition="'%(ProjectToBuild.Category)' == 'libs' and '$(LibrariesConfiguration)' != ''">Configuration=$(LibrariesConfiguration)</AdditionalProperties>
<AdditionalProperties Condition="'%(ProjectToBuild.Category)' == 'clr' and '$(CoreCLRConfiguration)' != ''">%(AdditionalProperties);Configuration=$(CoreCLRConfiguration)</AdditionalProperties>
<AdditionalProperties Condition="'%(ProjectToBuild.Category)' == 'mono' and '$(MonoConfiguration)' != ''">%(AdditionalProperties);Configuration=$(MonoConfiguration)</AdditionalProperties>
<AdditionalProperties Condition="'%(ProjectToBuild.Category)' == 'libs' and '$(LibrariesConfiguration)' != ''">%(AdditionalProperties);Configuration=$(LibrariesConfiguration)</AdditionalProperties>
</ProjectToBuild>
</ItemGroup>

Expand Down
Loading