Update roslyn-sdk analyzer sample #4379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
BillWagner
reviewed
Mar 5, 2021
There was a problem hiding this comment.
The code looks great @Youssef1313
I had one comment on the filenames. Once we resolve that, this is great.
| @@ -0,0 +1,26 @@ | |||
| using Microsoft.CodeAnalysis.CSharp.Testing; | |||
There was a problem hiding this comment.
I'm curious.
This file, and several others, have strange name (the + and the ` character.) Is that intentional? And why?
There was a problem hiding this comment.
@BillWagner This is what the default template has. The naming for this is made the same as the symbol metadata name.
BillWagner
approved these changes
Mar 8, 2021
There was a problem hiding this comment.
This LGTM.
Thanks for all this work @Youssef1313 It's really good work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #4378