Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify Observers if Element changed with Index[] #4598

Merged
merged 1 commit into from
May 25, 2021
Merged

Notify Observers if Element changed with Index[] #4598

merged 1 commit into from
May 25, 2021

Conversation

ngoetti
Copy link
Contributor

@ngoetti ngoetti commented May 25, 2021

Are there any downsides to this? I needed to make this adjustment so that I could properly bind to elements in the Dictionary.

Summary

Notify Observers if Element changed with Index[]

Are there any downsides to this? I needed to make this adjustment so that I could properly bind to elements in the Dictionary.
@ngoetti ngoetti requested a review from BillWagner as a code owner May 25, 2021 12:03
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change @ngoetti I like the addition. I've reviewed the changes, and I'll :shipit: now.

@BillWagner BillWagner merged commit 4a5c63d into dotnet:main May 25, 2021
@ngoetti ngoetti deleted the patch-1 branch May 25, 2021 12:35
patilb pushed a commit to patilb/samples that referenced this pull request May 31, 2021
Are there any downsides to this? I needed to make this adjustment so that I could properly bind to elements in the Dictionary.
patilb pushed a commit to patilb/samples that referenced this pull request May 31, 2021
Are there any downsides to this? I needed to make this adjustment so that I could properly bind to elements in the Dictionary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants