Skip to content

Commit

Permalink
Update comments for Windows SDK special casing
Browse files Browse the repository at this point in the history
Co-authored-by: Daniel Plaisted <[email protected]>
  • Loading branch information
Sergio0694 and dsplaisted committed Aug 23, 2024
1 parent 4763b7c commit 6c72933
Showing 1 changed file with 2 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,8 @@ protected override void ExecuteCore()
.Where(matchingRTReference => runtimePack.GetMetadata("FrameworkName").Equals(matchingRTReference.ItemSpec))
.Select(matchingRTReference => matchingRTReference.GetMetadata("Profile")).ToHashSet() ?? [];

// Special case the Windows SDK projections. These are in a runtime pack, not a runtime framework, but they also
// use profiles. Right now there are no other runtime packs using profiles, so we can special case these to keep
// the changes to a minimum and reduce risk. This logic can be revisited later to be generalized in some way.
// Special case the Windows SDK projections. Normally the Profile information flows through the RuntimeFramework items,
// but those aren't created for RuntimePackAlwaysCopyLocal references. This logic could be revisited later to be generalized in some way.
if (runtimePack.GetMetadata(MetadataKeys.FrameworkName) == "Microsoft.Windows.SDK.NET.Ref")
{
if (FrameworkReferences?.Any(fxReference => fxReference.ItemSpec == "Microsoft.Windows.SDK.NET.Ref.Windows") == true)
Expand Down

0 comments on commit 6c72933

Please sign in to comment.