-a sets app to framework-dependent when SelfContained is true

[richlander]

I'm working on some samples and following the excellent guidance at https://devblogs.microsoft.com/dotnet/improving-multiplatform-container-support/. The guidance doesn't work as intended when I target SCD.

My project file.

<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>net8.0</TargetFramework>
    <ImplicitUsings>enable</ImplicitUsings>
    <Nullable>enable</Nullable>
    <PublishSingleFile>true</PublishSingleFile>
    <PublishTrimmed>true</PublishTrimmed>
    <PublishReadyToRun>true</PublishReadyToRun>
    <PublishSelfContained>true</PublishSelfContained>
  </PropertyGroup>

</Project>

In Dockerfile:

# copy csproj and restore as distinct layers
COPY *.csproj .
RUN dotnet restore -a $TARGETARCH

# copy and publish app and libraries
COPY . .
RUN dotnet publish -a $TARGETARCH -o /app

This fails.

5.453 /root/.nuget/packages/microsoft.net.illink.tasks/8.0.0-preview.6.23329.7/build/Microsoft.NET.ILLink.targets(193,5): error NETSDK1102: Optimizing assemblies for size is not supported for the selected publish configuration. Please ensure that you are publishing a self-contained app. [/source/releases.csproj]

Works if I do:

RUN dotnet publish -a $TARGETARCH -o /app --self-contained

We should fix -a to be less strong. It should not override SelfContained or PublishSelfContained if set.

[ghost]

@dotnet/illink-contrib a new issue has been filed in the ILLink area, please triage

[nagilson]

Interesting, yeah it looks like the RID Short-Hand Resolution is called by the Architecture Flag, and if you haven't specified SelfContained then it will inject this:

properties = properties.Append("-property:SelfContained=false").ToArray(); , and since it's injected as a global property it would override your selfcontained or publishselfcontained value.

Not great, good catch! We should fix this. Marking as 'team triage' to discuss timeline.

[richlander]

-property:SelfContained=false") ... That shouldn't be needed anymore, right?

[nagilson]

Ya, that really shouldn't be there anymore. It is definitely going to break people when we fix it (yay) but it should be fixed.

[ghost]

Added needs-breaking-change-doc-created label because this issue has the breaking-change label.

1. Create and link to this issue a matching issue in the dotnet/docs repo using the breaking change documentation template, then remove this needs-breaking-change-doc-created label.

Tagging @dotnet/compat for awareness of the breaking change.

[nagilson]

Fix is targeted for rc1 as its too late to fix this for the last preview now

[richlander]

What is the PR for this change @nagilson?

[mthalman]

@nagilson - Is this fixed in RC1 yet?

[baronfel]

No, we haven't done it yet. I'll bring it up at standup today and we'll get it prioritized. Noah's been doing a lot of work on the VSCode extension to support DevKit, and this got lost in the shuffle.

[nagilson]

This has been solved by @MiYanni for RC-2. Sorry for forgetting this one, it got put down a continuously growing list for CDK 😄 Thanks again @MiYanni for taking this one up, a document has also been made which @baronfel attached.