Update symbols handling #4951
Closed
Update symbols handling #4951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbussell
approved these changes
Apr 25, 2024
mthalman
reviewed
Apr 26, 2024
Comment on lines
+8
to
+10
| RUN --mount=type=cache,target=/root/.nuget \ | ||
| --mount=type=cache,target=/source/bin \ | ||
| --mount=type=cache,target=/source/obj \ |
There was a problem hiding this comment.
Why is this pattern only done for this sample?
There was a problem hiding this comment.
Seems like this should be split into 2 PRs - one for stripping symbols and one for cache mounting.
There was a problem hiding this comment.
I added the cache mounting because this sample downloads a lot of files not in the SDK. This is a question we should discuss. What's our approach for caching? The layer caching only works so well. Also, the docker init samples for .NET do exactly this.
|
Closing so that we can re-visit this with #5057 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The native AOT folks told me the new approach for stripping symbols.
I was able to validate that cache mounts save time. It's possible not all the mounts are needed. I didn't validate that. Perhaps we can take a more systematic approach with logs to decide which ones are providing value.
The
-abug is resolved, per dotnet/sdk#34026@baronfel -- is there a good way for us to validate which cache mounts are providing benefit? We want to see which assets are downloaded fresh and then which are not on subsequent builds.