Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RID-specific targets section from assets file is being used for compile assets. #592

Closed
ericstj opened this issue Jan 5, 2017 · 1 comment · Fixed by #836
Closed

RID-specific targets section from assets file is being used for compile assets. #592

ericstj opened this issue Jan 5, 2017 · 1 comment · Fixed by #836
Assignees
Labels
Milestone

Comments

@ericstj
Copy link
Member

ericstj commented Jan 5, 2017

When compiling a project that sets a RuntimeIdentifier we should select the compile assets from the RID-less target in the assets.json, but select the runtime assets from the RID-specific target. It seems that this is not happening.

Repro:
https://gist.github.com/ericstj/452c243859cdc5f88da084d205bc73e9

dotnet restore
dotnet build

notice conflict errors. There are various other errors later on which may or not be related, but I'd expect this to build (not run) as is.

The relevant code in the old task that did this was https://github.com/NuGet/NuGet.BuildTasks/blob/4a57a0ef4bee31f122d50a39fe3dddd4ca03fb07/src/Microsoft.NuGet.Build.Tasks/ResolveNuGetPackageAssets.cs#L303.

/cc @natidea @jasonmalinowski

@dsplaisted
Copy link
Member

What do the conflict errors look like? Could this be the cause of #514?

@srivatsn srivatsn added the Bug label Jan 7, 2017
@srivatsn srivatsn modified the milestones: 1.0 RC3, 1.0 RTM Jan 7, 2017
mmitche added a commit to mmitche/sdk that referenced this issue Jun 5, 2020
…46-1b34-48aa-8c87-f208e1371148

[release/3.0.1xx] Update dependencies from aspnet/AspNetCore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants