Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution-level error when a RuntimeIdentifier is specified #863

Closed
rainersigwald opened this issue Feb 13, 2017 · 7 comments · Fixed by #12126
Closed

Solution-level error when a RuntimeIdentifier is specified #863

rainersigwald opened this issue Feb 13, 2017 · 7 comments · Fixed by #12126
Assignees
@sfoslund
Milestone
5.0.1xx

Comments

@rainersigwald
Copy link
Member

Related to a subset of #696 that won't be fixed by #828.

If a solution build has a RID specified, it will fail.

This can be because (after #828) it double-builds a library (once with RID specified from the solution's global properties, once with it removed):
sln race

Or, if nothing is done, this will fail when attempting to specify a RID on a project that doesn't need one.

If VS and the CLI distributed a solution-extension target that ran before Build and errored when '$(RuntimeIdentifier)' != '', it would at least provide guiderails to nudge users back into the more supported scenarios. It could say something like Building a solution with a specific RuntimeIdentifier is not supported. If you would like to publish for a single RID, specifiy the RID at the individual project level instead.
@livarcocc livarcocc added this to the 2.0 M1 milestone Apr 19, 2017
@livarcocc livarcocc modified the milestones: 2.1.0, 2.2.0 May 25, 2017
@rainersigwald rainersigwald mentioned this issue Sep 19, 2019
Closed
@rainersigwald rainersigwald mentioned this issue Mar 25, 2020
Closed
@gsmachado gsmachado mentioned this issue Mar 31, 2020
Closed
@benmccallum

This comment has been minimized.

Sign in to view
@benmccallum

This comment has been minimized.

Sign in to view
@dsplaisted dsplaisted modified the milestones: 2.3.0, 5.0.1xx Apr 9, 2020
@dsplaisted
Copy link
Member

@sfoslund If you're looking for issues to tackle, this one is a candidate

@benmccallum

This comment has been minimized.

Sign in to view
@benmccallum

This comment has been minimized.

Sign in to view
@benmccallum

This comment has been minimized.

Sign in to view
@benmccallum benmccallum mentioned this issue Apr 14, 2020
Open
@benmccallum
Copy link

I've split off my issues into the one linked above since it's still happening regardless of a runtime id.

@marcpopMSFT marcpopMSFT added the untriaged Request triage from a team member label Apr 16, 2020
@sfoslund sfoslund removed the untriaged Request triage from a team member label Apr 20, 2020
mmitche pushed a commit to mmitche/sdk that referenced this issue Jun 5, 2020
@dotnet-maestro
Update dependencies from https://github.com/aspnet/AspNetCore build 2…
d09fad2 
…0190808.9 (dotnet#863)

- Microsoft.AspNetCore.Mvc.Analyzers - 3.0.0-preview9.19408.9
- Microsoft.AspNetCore.Mvc.Api.Analyzers - 3.0.0-preview9.19408.9
- Microsoft.AspNetCore.Analyzers - 3.0.0-preview9.19408.9
- Microsoft.AspNetCore.Components.Analyzers - 3.0.0-preview9.19408.9
@sfoslund sfoslund mentioned this issue Jun 22, 2020
Merged
@marcpopMSFT marcpopMSFT mentioned this issue Oct 28, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sfoslund sfoslund

Labels
None yet
Projects
None yet
Milestone
5.0.1xx
Development

Successfully merging a pull request may close this issue.

Error on runtime identifier specified at solution level sfoslund/sdk
6 participants
@dsplaisted @benmccallum @livarcocc @rainersigwald @marcpopMSFT @sfoslund