Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[master] Update dependencies from mono/linker #12889

Merged
merged 6 commits into from
Aug 17, 2020
Merged

[master] Update dependencies from mono/linker #12889

merged 6 commits into from
Aug 17, 2020

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Aug 12, 2020 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/mono/linker

  • Subscription: 769e6472-e796-4bcb-a0ac-08d7dbf4acc5
  • Build: 20200814.2
  • Date Produced: 8/14/2020 10:33 PM
  • Commit: d5d4dc7d20d8c2a0389079bd56fb4a0b161cc2e3
  • Branch: refs/heads/master
  • Updates:
    • Microsoft.NET.ILLink.Tasks: from 5.0.0-preview.3.20410.2 to 5.0.0-preview.3.20414.2

@dotnet-maestro
Update dependencies from https://github.com/mono/linker build 20200812.1
6534528 
Microsoft.NET.ILLink.Tasks
 From Version 5.0.0-preview.3.20410.2 -> To Version 5.0.0-preview.3.20412.1
@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Aug 12, 2020 •
edited
Loading

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❓ Waiting on checks: dotnet-sdk-public-ci, dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Release), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Release), dotnet-sdk-public-ci (Build Darwin Build_Release), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Debug), dotnet-sdk-public-ci (Build Windows_NT Build_Release), dotnet-sdk-public-ci (Build Darwin Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Debug), dotnet-sdk-public-ci (Build Windows_NT Build_Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

dotnet-maestro bot and others added 2 commits August 13, 2020 14:28
@dotnet-maestro
Update dependencies from https://github.com/mono/linker build 20200813.1
442e12e 
Microsoft.NET.ILLink.Tasks
 From Version 5.0.0-preview.3.20410.2 -> To Version 5.0.0-preview.3.20413.1
@sbomer
Renumber warnings
03ef385 
To reflect the changes in dotnet/linker#1385
@sbomer sbomer requested review from vitek-karas and eerhardt August 14, 2020 16:39
@sbomer
Suppress more trim analysis warnings
1d3018b 
The following also belong to the trim analysis category:
- IL2050 (dotnet/linker#1430)
- Warnings about invalid attributes
- Warnings about uses of removed attributes
@eerhardt
Copy link
Member 

  <NoWarn Condition=" !$(RuntimeIdentifier.StartsWith('win')) ">$(NoWarn);IL2009</NoWarn> <!-- Unresolved member on type referenced in XML. -->

According to https://github.com/dotnet/runtime/pull/40691/files/1e36100bd16a4f1094e4dc6537b4daf4417a84ea#diff-749a6d32ee50a25c6076a389e2c805e3R25

IL2009 can happen on non-x64 platforms as well...

IL2009: Could not find method 'GetStubContextAddr' in type 'System.StubHelpers.StubHelpers'

Refers to: src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.ILLink.targets:179 in 1d3018b. [](commit_id = 1d3018b, deletion_comment = False)

eerhardt
eerhardt approved these changes Aug 14, 2020
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If @vitek-karas thinks all the right warning codes are suppressed, that's good enough for me 😄

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Aug 14, 2020 •
edited
Loading

Auto-Merge Status

This pull request has been merged because the following merge policies have succeeded.

  • ✔️ Standard Merge Policies Succeeded - Successful checks: dotnet-sdk-public-ci, dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Release), dotnet-sdk-public-ci (Build Windows_NT_FullFramework Build_Debug), dotnet-sdk-public-ci (Build Darwin Build_Debug), dotnet-sdk-public-ci (Build Windows_NT_TestAsTools Build_Debug), dotnet-sdk-public-ci (Build Windows_NT Build_Release), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Release), dotnet-sdk-public-ci (Build Darwin Build_Release), dotnet-sdk-public-ci (Build Windows_NT Build_Debug), dotnet-sdk-public-ci (Build Ubuntu_16_04 Build_Debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

sbomer and others added 2 commits August 14, 2020 23:07
@sbomer
Suppress IL2009 on 32-bit
fd0d182 
GetStubContextAddr rooted by the corelib XML only exists on 64-bit.
@dotnet-maestro
Update dependencies from https://github.com/mono/linker build 20200814.2
eb852fd 
Microsoft.NET.ILLink.Tasks
 From Version 5.0.0-preview.3.20410.2 -> To Version 5.0.0-preview.3.20414.2
@dotnet-maestro dotnet-maestro bot merged commit cc3931e into master Aug 17, 2020
@dotnet-maestro dotnet-maestro bot deleted the darc-master-417dc6cd-6b2b-4d46-bd3f-3bad5b3ef798 branch August 17, 2020 00:05
@runfoapp runfoapp bot mentioned this pull request Sep 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eerhardt eerhardt eerhardt approved these changes

@vitek-karas vitek-karas vitek-karas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eerhardt @vitek-karas @sbomer