Add vulnerable option to dotnet list package #13318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wli3
reviewed
Sep 2, 2020
| /// these options must not be used, so error is thrown. | ||
| /// </summary> | ||
| /// <param name="option"></param> | ||
| private void CheckForOutdatedOrDeprecated(string option) | ||
| private void CheckForOnlineOptions(string option) |
There was a problem hiding this comment.
Options that require online lookups to services for their information
There was a problem hiding this comment.
(code removed per main comment above)
wli3
reviewed
Sep 2, 2020
| { | ||
| if (!_appliedCommand.HasOption("deprecated") && !_appliedCommand.HasOption("outdated")) | ||
| if (!_appliedCommand.HasOption("deprecated") && !_appliedCommand.HasOption("outdated") && !_appliedCommand.HasOption("vulnerable")) |
drewgillies
force-pushed
the
add-cli-list-package-vulnerable
branch
from
fb9c6c0 to
c5fc6b8
Compare
drewgillies
force-pushed
the
add-cli-list-package-vulnerable
branch
from
c5fc6b8 to
a3daf70
Compare
drewgillies
force-pushed
the
add-cli-list-package-vulnerable
branch
from
a3daf70 to
ea4fde6
Compare
wli3
approved these changes
Sep 24, 2020
|
@drewgillies merging this into master for 6.0. If you want this included in 5.0.2xx, you'll need to port it over once we have that servicing branch (~1 month out) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
--vulnerableoption todotnet list packageCLI. Also removed most of the "policing" around other option combinations:--include-prerelease,--highest-minor, andhighest-patchare only supposed to be used in combination with the--outdatedoption, but they're just ignored by the NuGet Xplat CLI otherwise, and we'll do the same here.--configand--sourceare only supposed to be used in combination with--vulnerable,--outdatedand--deprecatedreports, but they're also just ignored by the NuGet Xplat CLI, so we'll ignore them here.--vulnerable,--outdatedand--deprecatedall must be used mutually exclusively, and combining them is nonsense--we throw in the NuGet Xplat CLI in this case, and we'll continue to throw here.